LayoutTests/http/tests/notifications/serviceworkerregistration-document-not-activated.html - Issue 1100163002: Notifications: stop using notifications specific permission methods in LayoutTests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/notifications/serviceworkerregistration-document-not-activated.html

Issue 1100163002: Notifications: stop using notifications specific permission methods in LayoutTests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@notifications_testrunner_setpermission

Patch Set: update Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/notifications/serviceworkerregistration-document-no-permission.html ('k') | LayoutTests/http/tests/notifications/serviceworkerregistration-document-vibrate-throw.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/notifications/serviceworkerregistration-document-not-activated.html

diff --git a/LayoutTests/http/tests/notifications/serviceworkerregistration-document-not-activated.html b/LayoutTests/http/tests/notifications/serviceworkerregistration-document-not-activated.html

index 131f0b45379ec2eebdd409b4d2be72fd116cdd64..158bed0cf9ab99fd92f6dfa0d70f7e3f607944a7 100644

--- a/LayoutTests/http/tests/notifications/serviceworkerregistration-document-not-activated.html

+++ b/LayoutTests/http/tests/notifications/serviceworkerregistration-document-not-activated.html

@@ -14,10 +14,8 @@

var scope = 'resources/scope/service-worker-show-notification-not-activated',

workerUrl = 'resources/empty-worker.js';

- if (window.testRunner) {

+ if (window.testRunner)

testRunner.setPermission('notifications', 'denied', location.origin, location.origin);

- testRunner.grantWebNotificationPermission(location.origin, false);

- }

service_worker_unregister_and_register(test, workerUrl, scope).then(function(registration) {

assert_inherits(registration, 'showNotification', 'showNotification() must be exposed.');