LayoutTests/http/tests/security/suborigins/suborigin-blocked-notifications.php - Issue 1100163002: Notifications: stop using notifications specific permission methods in LayoutTests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/security/suborigins/suborigin-blocked-notifications.php

Issue 1100163002: Notifications: stop using notifications specific permission methods in LayoutTests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@notifications_testrunner_setpermission

Patch Set: update Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/notifications/update-shared-worker.html ('k') | LayoutTests/http/tests/serviceworker/chromium/clients-openwindow.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/security/suborigins/suborigin-blocked-notifications.php

diff --git a/LayoutTests/http/tests/security/suborigins/suborigin-blocked-notifications.php b/LayoutTests/http/tests/security/suborigins/suborigin-blocked-notifications.php

index 159800198b469969af6e4fd0b459a736822a00fe..b3802def35fcca1d9875701a525acf13f83092d2 100644

--- a/LayoutTests/http/tests/security/suborigins/suborigin-blocked-notifications.php

+++ b/LayoutTests/http/tests/security/suborigins/suborigin-blocked-notifications.php

@@ -10,7 +10,6 @@ header("Content-Security-Policy: suborigin foobar");

</head>

testRunner.setPermission('notifications', 'granted', location.origin, location.origin);

- testRunner.grantWebNotificationPermission(location.origin, true);

Notification.requestPermission(function (status) {

assert_equals(status, 'default', 'The notification permission request should not be granted.');