LayoutTests/http/tests/notifications/permission-document.html - Issue 1100163002: Notifications: stop using notifications specific permission methods in LayoutTests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/notifications/permission-document.html

Issue 1100163002: Notifications: stop using notifications specific permission methods in LayoutTests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@notifications_testrunner_setpermission

Patch Set: update Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/notifications/notification-sandbox-permission-expected.txt ('k') | LayoutTests/http/tests/notifications/request-permission-denied.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/notifications/permission-document.html

diff --git a/LayoutTests/http/tests/notifications/permission-document.html b/LayoutTests/http/tests/notifications/permission-document.html

index 7c1ecdf69ccf2816a6d55f9062fe4d28e666edb4..cb1751a1d15ab1ea6e4b76b1f3ca9f43c01a72de 100644

--- a/LayoutTests/http/tests/notifications/permission-document.html

+++ b/LayoutTests/http/tests/notifications/permission-document.html

@@ -14,19 +14,12 @@

// is correctly updated before calling Notification.permission because

// testRunner.setPermission() and Notification.permission might end up

// in a race given the synchronous aspect of the latter.

- if (window.testRunner) {

- testRunner.setPermission('notifications', 'granted', location.origin, location.origin);

- testRunner.grantWebNotificationPermission(location.origin, true);

- }

var notificationsPermissionsTest = async_test("Notification.permission reflects th actual permission.");

var testIndex = 0;

var tests = [

function() {

testRunner.setPermission('notifications', 'prompt', location.origin, location.origin);

- testRunner.clearWebNotificationPermissions();

navigator.permissions.query({name:'notifications'}).then(function() {

// "default" indicates that no permission request has been answered.

assert_equals(Notification.permission, 'default');

@@ -36,8 +29,6 @@

function() {

testRunner.setPermission('notifications', 'denied', location.origin, location.origin);

- testRunner.grantWebNotificationPermission(location.origin, false);

navigator.permissions.query({name:'notifications'}).then(function() {

// "default" indicates that no permission request has been answered.

assert_equals(Notification.permission, 'denied');

@@ -47,8 +38,6 @@

function () {

testRunner.setPermission('notifications', 'granted', location.origin, location.origin);

- testRunner.grantWebNotificationPermission(location.origin, true);

navigator.permissions.query({name:'notifications'}).then(function() {

// "default" indicates that no permission request has been answered.

assert_equals(Notification.permission, 'granted');