Removed obsolete float_util.h as VS2013 supports standards well enough.

Removed obsolete float_util.h as VS2013 supports standards well enough.

BUG=

Committed: https://crrev.com/3371ab09fb14093f9f5f5db41a60d98b215217c1
Cr-Commit-Position: refs/heads/master@{#326781}

[Mateusz Szymański, 2015-04-08 15:11:01]

mateuszs@opera.com changed reviewers:
+ darin@chromium.org

[Mateusz Szymański, 2015-04-08 15:12:02]

mateuszs@opera.com changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2015-04-08 18:04:37]

Please review the rest of the CL for #include <cmath> yourself. I got halfway
through and saw that the same thing kept coming up repeatedly.

https://codereview.chromium.org/1076443002/diff/1/base/float_util.h
File base/float_util.h (left):

https://codereview.chromium.org/1076443002/diff/1/base/float_util.h#oldcode1
base/float_util.h:1: // Copyright (c) 2012 The Chromium Authors. All rights
reserved.
The CL description called this file float_utils.h, but that’s not the right
name.

https://codereview.chromium.org/1076443002/diff/1/base/trace_event/trace_even...
File base/trace_event/trace_event_impl.cc (right):

https://codereview.chromium.org/1076443002/diff/1/base/trace_event/trace_even...
base/trace_event/trace_event_impl.cc:7: #include <algorithm>
#include <cmath>

https://codereview.chromium.org/1076443002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/motion_event_android.cc (right):

https://codereview.chromium.org/1076443002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/motion_event_android.cc:8: #include <cmath>
Leave a blank line between C system headers and C++ system headers.

https://codereview.chromium.org/1076443002/diff/1/content/child/v8_value_conv...
File content/child/v8_value_converter_impl.cc (right):

https://codereview.chromium.org/1076443002/diff/1/content/child/v8_value_conv...
content/child/v8_value_converter_impl.cc:311: if (std::isinf(val_as_double))
#include <cmath>

https://codereview.chromium.org/1076443002/diff/1/content/common/page_state_s...
File content/common/page_state_serialization_unittest.cc (right):

https://codereview.chromium.org/1076443002/diff/1/content/common/page_state_s...
content/common/page_state_serialization_unittest.cc:49: if
(!(std::isnan(a.file_modification_time) &&
#include <cmath>

[Mateusz Szymański, 2015-04-09 07:32:52]

https://codereview.chromium.org/1076443002/diff/1/base/float_util.h
File base/float_util.h (left):

https://codereview.chromium.org/1076443002/diff/1/base/float_util.h#oldcode1
base/float_util.h:1: // Copyright (c) 2012 The Chromium Authors. All rights
reserved.
On 2015/04/08 18:04:37, Mark Mentovai wrote:
> The CL description called this file float_utils.h, but that’s not the right
> name.

Done.

https://codereview.chromium.org/1076443002/diff/1/base/trace_event/trace_even...
File base/trace_event/trace_event_impl.cc (right):

https://codereview.chromium.org/1076443002/diff/1/base/trace_event/trace_even...
base/trace_event/trace_event_impl.cc:7: #include <algorithm>
On 2015/04/08 18:04:37, Mark Mentovai wrote:
> #include <cmath>

Done.

https://codereview.chromium.org/1076443002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/motion_event_android.cc (right):

https://codereview.chromium.org/1076443002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/motion_event_android.cc:8: #include <cmath>
On 2015/04/08 18:04:37, Mark Mentovai wrote:
> Leave a blank line between C system headers and C++ system headers.

Done.

https://codereview.chromium.org/1076443002/diff/1/content/child/v8_value_conv...
File content/child/v8_value_converter_impl.cc (right):

https://codereview.chromium.org/1076443002/diff/1/content/child/v8_value_conv...
content/child/v8_value_converter_impl.cc:311: if (std::isinf(val_as_double))
On 2015/04/08 18:04:37, Mark Mentovai wrote:
> #include <cmath>

Done.

[Mark Mentovai, 2015-04-09 12:46:37]

https://codereview.chromium.org/1076443002/diff/20001/content/renderer/java/g...
File content/renderer/java/gin_java_bridge_value_converter.cc (right):

https://codereview.chromium.org/1076443002/diff/20001/content/renderer/java/g...
content/renderer/java/gin_java_bridge_value_converter.cc:150: if
(std::isfinite(double_value))
#include <cmath>

https://codereview.chromium.org/1076443002/diff/20001/content/renderer/media/...
File content/renderer/media/media_stream_audio_level_calculator.cc (right):

https://codereview.chromium.org/1076443002/diff/20001/content/renderer/media/...
content/renderer/media/media_stream_audio_level_calculator.cc:23:
DCHECK(std::isfinite(max));
#include <cmath>. I asked you to self-review to find other instances of this.
The two I’ve called out aren’t the only ones that have been omitted in patch set
2. If you’re not going to take the time to find them, why should I?

[Mateusz Szymański, 2015-04-09 15:32:29]

I'm sorry, I didn't notice your request to look through all the remaining code.

https://codereview.chromium.org/1076443002/diff/20001/content/renderer/media/...
File content/renderer/media/media_stream_audio_level_calculator.cc (right):

https://codereview.chromium.org/1076443002/diff/20001/content/renderer/media/...
content/renderer/media/media_stream_audio_level_calculator.cc:23:
DCHECK(std::isfinite(max));
On 2015/04/09 12:46:37, Mark Mentovai wrote:
> #include <cmath>. I asked you to self-review to find other instances of this.
> The two I’ve called out aren’t the only ones that have been omitted in patch
set
> 2. If you’re not going to take the time to find them, why should I?

Done.

[Mark Mentovai, 2015-04-09 15:42:16]

I didn’t mean to add <cmath> everywhere "base/float_util.h" was. I meant to add
it in files where something from cmath is actually used. float_util.h was
#included more places than it was needed.

https://codereview.chromium.org/1076443002/diff/1/base/float_util.h
File base/float_util.h (left):

https://codereview.chromium.org/1076443002/diff/1/base/float_util.h#oldcode1
base/float_util.h:1: // Copyright (c) 2012 The Chromium Authors. All rights
reserved.
Mateusz Szymański wrote:
> On 2015/04/08 18:04:37, Mark Mentovai wrote:
> > The CL description called this file float_utils.h, but that’s not the right
> > name.
> 
> Done.

You edited the CL title which is just used for e-mail subjects, but you didn’t
fix the CL description which is what counts for check-in.

https://codereview.chromium.org/1076443002/diff/40001/chrome/browser/speech/t...
File chrome/browser/speech/tts_controller_impl.cc (right):

https://codereview.chromium.org/1076443002/diff/40001/chrome/browser/speech/t...
chrome/browser/speech/tts_controller_impl.cc:7: #include <cmath>
This file doesn’t use this.

https://codereview.chromium.org/1076443002/diff/40001/content/browser/rendere...
File content/browser/renderer_host/input/motion_event_android_unittest.cc
(right):

https://codereview.chromium.org/1076443002/diff/40001/content/browser/rendere...
content/browser/renderer_host/input/motion_event_android_unittest.cc:7: #include
<cmath>
Neither does this file.

https://codereview.chromium.org/1076443002/diff/40001/dbus/values_util_unitte...
File dbus/values_util_unittest.cc (right):

https://codereview.chromium.org/1076443002/diff/40001/dbus/values_util_unitte...
dbus/values_util_unittest.cc:7: #include <cmath>
Or this one.

https://codereview.chromium.org/1076443002/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder_autogen.h (right):

https://codereview.chromium.org/1076443002/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_autogen.h:9: // DO NOT EDIT!
Did you generate this file or just change it in-line?

https://codereview.chromium.org/1076443002/diff/40001/ui/gfx/range/range_f.cc
File ui/gfx/range/range_f.cc (right):

https://codereview.chromium.org/1076443002/diff/40001/ui/gfx/range/range_f.cc...
ui/gfx/range/range_f.cc:8: #include <cmath>
This file doesn’t use this either.

[Mateusz Szymański, 2015-04-14 10:30:15]

https://codereview.chromium.org/1076443002/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder_autogen.h (right):

https://codereview.chromium.org/1076443002/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_autogen.h:9: // DO NOT EDIT!
On 2015/04/09 15:42:15, Mark Mentovai wrote:
> Did you generate this file or just change it in-line?

I've edited it in-line but generating it yields the same result (but
changes/reorders some other files and I'm not willing to touch these).

[Mark Mentovai, 2015-04-14 12:41:54]

LGTM

[Mateusz Szymański, 2015-04-14 12:45:59]

The CQ bit was checked by mateuszs@opera.com

[commit-bot: I haz the power, 2015-04-14 12:46:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1076443002/60001

[commit-bot: I haz the power, 2015-04-14 12:55:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-14 12:55:21]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mateusz Szymański, 2015-04-14 14:22:11]

mateuszs@opera.com changed reviewers:
+ aelias@chromium.org, asvitkine@chromium.org, avi@chromium.org,
bajones@chromium.org, dmazzoni@chromium.org, jrummell@chromium.org,
mnaganov@chromium.org, satorux@chromium.org, tdresser@chromium.org,
tommi@chromium.org, wolenetz@chromium.org, yfriedman@google.com

[Mateusz Szymański, 2015-04-14 14:22:12]

Added reviewers for all the files.

[mnaganov (inactive), 2015-04-14 14:27:16]

Java Bridge stuff LGTM

[Yaron, 2015-04-14 14:28:06]

On 2015/04/14 14:27:16, mnaganov wrote:
> Java Bridge stuff LGTM

please specify which folder/files you want each owner to review

[Mateusz Szymański, 2015-04-14 14:52:44]

I'd love to have the following LGTMs:

jrummell, wolenetz: content/renderer/media, media/audio, media/blink (sorry to
have added both of you)
Avi: content/, content/child, content/common
aelias: content/browser/renderer/input
yfriedman: content/common/android
dmazzoni: browser/speech
Alexei Svitkine: ui/gfx
bajones: gpu/command_buffers
satorux1: dbus/
tdresser: ui/events
tommi: media/audio

[Alexei Svitkine (slow), 2015-04-14 14:56:02]

ui/gfx lgtm assuming bots pass

[Yaron, 2015-04-14 14:57:45]

yfriedman@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Yaron, 2015-04-14 14:57:46]

lgtm

[dmazzoni, 2015-04-14 15:51:08]

lgtm, but I suggest you ask one of the top-level owners to approve rather than
getting review from so many different owners

[Avi (use Gerrit), 2015-04-14 16:19:12]

content lgtm stampity stamp

[jrummell, 2015-04-14 17:15:29]

media lgtm

[aelias_OOO_until_Jul13, 2015-04-14 17:36:29]

lgtm

[wolenetz, 2015-04-14 18:26:16]

media/ and content/renderer/media lgtm

[satorux1, 2015-04-15 01:29:49]

dbus/values_util_unittest.cc lgtm. thanks!

[Mateusz Szymański, 2015-04-15 07:08:15]

The CQ bit was checked by mateuszs@opera.com

[commit-bot: I haz the power, 2015-04-15 07:08:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1076443002/60001

[commit-bot: I haz the power, 2015-04-15 07:14:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-15 07:14:21]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mateusz Szymański, 2015-04-16 07:33:24]

mateuszs@opera.com changed reviewers:
+ jbauman@chromium.org

[Mateusz Szymański, 2015-04-16 07:33:25]

+jbauman
Can you please have a look at gpu/command_buffer stuff?

[jbauman, 2015-04-16 23:03:22]

gpu/command_buffer lgtm

[Mateusz Szymański, 2015-04-17 07:30:24]

The CQ bit was checked by mateuszs@opera.com

[commit-bot: I haz the power, 2015-04-17 07:30:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1076443002/60001

[commit-bot: I haz the power, 2015-04-17 07:46:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-17 07:46:03]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mateusz Szymański, 2015-04-17 10:54:37]

On 2015/04/17 07:46:03, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Mark, can you please have a look at update GN file and tell me if you think
this'll fix this issue?

[Mark Mentovai, 2015-04-17 12:22:37]

https://chromium.googlesource.com/chromium/src/+log/master/cc/base/histograms.cc
is a new file that #includes float_util.h.

[tdresser, 2015-04-17 19:38:09]

ui/events/gesture_detection/scale_gesture_detector.cc LGTM with nit.

https://codereview.chromium.org/1076443002/diff/100001/ui/events/gesture_dete...
File ui/events/gesture_detection/scale_gesture_detector.cc (right):

https://codereview.chromium.org/1076443002/diff/100001/ui/events/gesture_dete...
ui/events/gesture_detection/scale_gesture_detector.cc:8: 
Was adding this space intentional?

[Mateusz Szymański, 2015-04-20 06:58:50]

https://codereview.chromium.org/1076443002/diff/100001/ui/events/gesture_dete...
File ui/events/gesture_detection/scale_gesture_detector.cc (right):

https://codereview.chromium.org/1076443002/diff/100001/ui/events/gesture_dete...
ui/events/gesture_detection/scale_gesture_detector.cc:8: 
On 2015/04/17 19:38:09, tdresser wrote:
> Was adding this space intentional?

Yes, as requested by Mark here
https://codereview.chromium.org/1076443002/diff/1/content/browser/renderer_ho...

[Mateusz Szymański, 2015-04-20 07:01:44]

mateuszs@opera.com changed reviewers:
+ jamesr@chromium.org

[Mateusz Szymański, 2015-04-20 07:01:45]

+jamesr, can you please have a look at cc/base changes?

[jamesr, 2015-04-20 16:41:17]

lgtm (I believe aelias had you covered for owners already, though)

[tommi (sloooow) - chröme, 2015-04-20 17:53:17]

lgtm

[Mateusz Szymański, 2015-04-21 06:58:21]

The CQ bit was checked by mateuszs@opera.com

[Mateusz Szymański, 2015-04-21 06:58:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
jrummell@chromium.org, aelias@chromium.org, avi@chromium.org, mark@chromium.org,
yfriedman@chromium.org, asvitkine@chromium.org, jbauman@chromium.org,
wolenetz@chromium.org, mnaganov@chromium.org, satorux@chromium.org,
dmazzoni@chromium.org, tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/1076443002/#ps120001
(title: "Updated new files.")

[commit-bot: I haz the power, 2015-04-21 06:58:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1076443002/120001

[commit-bot: I haz the power, 2015-04-21 09:09:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-21 09:09:46]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mateusz Szymański, 2015-04-21 14:26:27]

Avi, can you please have a look again at content/child?
I've made a mistake when replacing the original code.

[Mateusz Szymański, 2015-04-24 12:01:35]

The CQ bit was checked by mateuszs@opera.com

[Mateusz Szymański, 2015-04-24 12:01:36]

The patchset sent to the CQ was uploaded after l-g-t-m from jamesr@chromium.org,
aelias@chromium.org, jrummell@chromium.org, mnaganov@chromium.org,
avi@chromium.org, mark@chromium.org, yfriedman@chromium.org,
asvitkine@chromium.org, jbauman@chromium.org, wolenetz@chromium.org,
tommi@chromium.org, satorux@chromium.org, tdresser@chromium.org,
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1076443002/#ps140001
(title: "Fixed mistake in value converter.")

[commit-bot: I haz the power, 2015-04-24 12:01:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1076443002/140001

[commit-bot: I haz the power, 2015-04-24 13:20:41]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-04-24 13:21:28]

Patchset 8 (id:??) landed as
https://crrev.com/3371ab09fb14093f9f5f5db41a60d98b215217c1
Cr-Commit-Position: refs/heads/master@{#326781}