content/renderer/java/gin_java_bridge_value_converter_unittest.cc - Issue 1076443002: Removed obsolete float_util.h as VS2013 supports standards well enough.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/java/gin_java_bridge_value_converter_unittest.cc

Issue 1076443002: Removed obsolete float_util.h as VS2013 supports standards well enough. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Fixed mistake in value converter. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/java/gin_java_bridge_value_converter.cc ('k') | content/renderer/media/media_stream_audio_level_calculator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/java/gin_java_bridge_value_converter_unittest.cc

diff --git a/content/renderer/java/gin_java_bridge_value_converter_unittest.cc b/content/renderer/java/gin_java_bridge_value_converter_unittest.cc

index edffce70501acf35b2368082be6ac3d5c861f1cb..b0ef27a06d359436f6361ad2ab04aacd6e27f5eb 100644

--- a/content/renderer/java/gin_java_bridge_value_converter_unittest.cc

+++ b/content/renderer/java/gin_java_bridge_value_converter_unittest.cc

@@ -2,8 +2,9 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include <cmath>

#include "base/basictypes.h"

-#include "base/float_util.h"

#include "base/memory/scoped_ptr.h"

#include "base/strings/stringprintf.h"

#include "content/common/android/gin_java_bridge_value.h"

@@ -67,8 +68,7 @@ TEST_F(GinJavaBridgeValueConverterTest, BasicValues) {

EXPECT_TRUE(

infinity_value->IsType(GinJavaBridgeValue::TYPE_NONFINITE));

EXPECT_TRUE(infinity_value->GetAsNonFinite(&native_float));

- EXPECT_FALSE(base::IsFinite(native_float));

- EXPECT_FALSE(base::IsNaN(native_float));

+ EXPECT_TRUE(std::isinf(native_float));

}

TEST_F(GinJavaBridgeValueConverterTest, ArrayBuffer) {