content/renderer/java/gin_java_bridge_value_converter.cc - Issue 1076443002: Removed obsolete float_util.h as VS2013 supports standards well enough.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/java/gin_java_bridge_value_converter.cc

Issue 1076443002: Removed obsolete float_util.h as VS2013 supports standards well enough. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Fixed mistake in value converter. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/page_state_serialization_unittest.cc ('k') | content/renderer/java/gin_java_bridge_value_converter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/java/gin_java_bridge_value_converter.cc

diff --git a/content/renderer/java/gin_java_bridge_value_converter.cc b/content/renderer/java/gin_java_bridge_value_converter.cc

index c1727a42bb5681b3771ee7e4171f959ab94e4e30..64860822e0725b82d4f367f4b312a17be6dcfd90 100644

--- a/content/renderer/java/gin_java_bridge_value_converter.cc

+++ b/content/renderer/java/gin_java_bridge_value_converter.cc

@@ -4,7 +4,8 @@

#include "content/renderer/java/gin_java_bridge_value_converter.h"

-#include "base/float_util.h"

+#include <cmath>

#include "base/values.h"

#include "content/common/android/gin_java_bridge_value.h"

#include "content/renderer/java/gin_java_bridge_object.h"

@@ -148,7 +149,7 @@ bool GinJavaBridgeValueConverter::FromV8ArrayBuffer(

bool GinJavaBridgeValueConverter::FromV8Number(v8::Handle<v8::Number> value,

base::Value** out) const {

double double_value = value->Value();

- if (base::IsFinite(double_value))

+ if (std::isfinite(double_value))

return false;

*out = GinJavaBridgeValue::CreateNonFiniteValue(double_value).release();

return true;