base/values.cc - Issue 1076443002: Removed obsolete float_util.h as VS2013 supports standards well enough.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/values.cc

Issue 1076443002: Removed obsolete float_util.h as VS2013 supports standards well enough. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Fixed mistake in value converter. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/values.cc

diff --git a/base/values.cc b/base/values.cc

index 52876cf2c4fffff5b932d6c427418fedd75046a2..0e1e2b1bdd7740f442d0327dd472d5d9ea37946e 100644

--- a/base/values.cc

+++ b/base/values.cc

@@ -7,9 +7,9 @@

#include <string.h>

#include <algorithm>

+#include <cmath>

#include <ostream>

-#include "base/float_util.h"

#include "base/json/json_writer.h"

#include "base/logging.h"

#include "base/move.h"

@@ -175,7 +175,7 @@ FundamentalValue::FundamentalValue(int in_value)

FundamentalValue::FundamentalValue(double in_value)

: Value(TYPE_DOUBLE), double_value_(in_value) {

- if (!IsFinite(double_value_)) {

+ if (!std::isfinite(double_value_)) {

NOTREACHED() << "Non-finite (i.e. NaN or positive/negative infinity) "

<< "values cannot be represented in JSON";

double_value_ = 0.0;

« no previous file with comments | « base/trace_event/trace_event_impl.cc ('k') | cc/base/histograms.cc » ('j') | no next file with comments »