Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Unified Diff: content/common/android/gin_java_bridge_value_unittest.cc

Issue 1076443002: Removed obsolete float_util.h as VS2013 supports standards well enough. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Fixed mistake in value converter. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/v8_value_converter_impl.cc ('k') | content/common/page_state_serialization_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/android/gin_java_bridge_value_unittest.cc
diff --git a/content/common/android/gin_java_bridge_value_unittest.cc b/content/common/android/gin_java_bridge_value_unittest.cc
index 72a0ea87a0e311e1f1c563a37466034522bb7a42..02768488d5c3176f631b4bfdeab9bab55ad21c58 100644
--- a/content/common/android/gin_java_bridge_value_unittest.cc
+++ b/content/common/android/gin_java_bridge_value_unittest.cc
@@ -2,8 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include <cmath>
+
#include "base/basictypes.h"
-#include "base/float_util.h"
#include "base/memory/scoped_ptr.h"
#include "content/common/android/gin_java_bridge_value.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -40,8 +41,7 @@ TEST_F(GinJavaBridgeValueTest, BasicValues) {
ASSERT_TRUE(float_infinity_value.get());
EXPECT_TRUE(float_infinity_value->IsType(GinJavaBridgeValue::TYPE_NONFINITE));
EXPECT_TRUE(float_infinity_value->GetAsNonFinite(&native_float));
- EXPECT_FALSE(base::IsFinite(native_float));
- EXPECT_FALSE(base::IsNaN(native_float));
+ EXPECT_TRUE(std::isinf(native_float));
EXPECT_FALSE(undefined_value->GetAsObjectID(&native_object_id));
@@ -57,8 +57,7 @@ TEST_F(GinJavaBridgeValueTest, BasicValues) {
EXPECT_TRUE(
double_infinity_value->IsType(GinJavaBridgeValue::TYPE_NONFINITE));
EXPECT_TRUE(double_infinity_value->GetAsNonFinite(&native_float));
- EXPECT_FALSE(base::IsFinite(native_float));
- EXPECT_FALSE(base::IsNaN(native_float));
+ EXPECT_TRUE(std::isinf(native_float));
EXPECT_FALSE(undefined_value->GetAsObjectID(&native_object_id));
« no previous file with comments | « content/child/v8_value_converter_impl.cc ('k') | content/common/page_state_serialization_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698