content/child/v8_value_converter_impl.cc - Issue 1076443002: Removed obsolete float_util.h as VS2013 supports standards well enough.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/v8_value_converter_impl.cc

Issue 1076443002: Removed obsolete float_util.h as VS2013 supports standards well enough. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Fixed mistake in value converter. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/motion_event_android_unittest.cc ('k') | content/common/android/gin_java_bridge_value_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/v8_value_converter_impl.cc

diff --git a/content/child/v8_value_converter_impl.cc b/content/child/v8_value_converter_impl.cc

index 6ff87974a4951ca2fd7d6e7fdc28a68b79a0d2c1..9efd42998105dcf9a7f31552a101670bc89dbbc1 100644

--- a/content/child/v8_value_converter_impl.cc

+++ b/content/child/v8_value_converter_impl.cc

@@ -4,11 +4,11 @@

#include "content/child/v8_value_converter_impl.h"

+#include <cmath>

#include <string>

#include "base/bind.h"

#include "base/bind_helpers.h"

-#include "base/float_util.h"

#include "base/logging.h"

#include "base/memory/scoped_ptr.h"

#include "base/values.h"

@@ -309,7 +309,7 @@ base::Value* V8ValueConverterImpl::FromV8ValueImpl(

if (val->IsNumber()) {

double val_as_double = val.As<v8::Number>()->Value();

- if (!base::IsFinite(val_as_double))

+ if (!std::isfinite(val_as_double))

return NULL;

return new base::FundamentalValue(val_as_double);

}