media/blink/webmediaplayer_impl.cc - Issue 1076443002: Removed obsolete float_util.h as VS2013 supports standards well enough.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 1076443002: Removed obsolete float_util.h as VS2013 supports standards well enough. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Fixed mistake in value converter. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/blink/webmediaplayer_impl.cc

diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc

index 8fa7a7f57f25761458bd9a4298c0816e0652703a..13c8714fcbe7c8462fbcd66fda17f517101d1ed7 100644

--- a/media/blink/webmediaplayer_impl.cc

+++ b/media/blink/webmediaplayer_impl.cc

@@ -5,6 +5,7 @@

#include "media/blink/webmediaplayer_impl.h"

#include <algorithm>

+#include <cmath>

#include <limits>

#include <string>

#include <vector>

@@ -14,7 +15,6 @@

#include "base/callback_helpers.h"

#include "base/debug/alias.h"

#include "base/debug/crash_logging.h"

-#include "base/float_util.h"

#include "base/message_loop/message_loop_proxy.h"

#include "base/metrics/histogram.h"

#include "base/single_thread_task_runner.h"

@@ -486,7 +486,7 @@ blink::WebTimeRanges WebMediaPlayerImpl::seekable() const {

// Allow a special exception for seeks to zero for streaming sources with a

// finite duration; this allows looping to work.

const bool allow_seek_to_zero = data_source_ && data_source_->IsStreaming() &&

- base::IsFinite(seekable_end);

+ std::isfinite(seekable_end);

// TODO(dalecurtis): Technically this allows seeking on media which return an

// infinite duration so long as DataSource::IsStreaming() is false. While not

« no previous file with comments | « media/audio/audio_power_monitor.cc ('k') | media/blink/websourcebuffer_impl.cc » ('j') | no next file with comments »