Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 1074683002: [bindings] Use Local<> instead of Handle<> (Closed)

Created:
5 years, 8 months ago by deepak.s
Modified:
5 years, 8 months ago
CC:
blink-reviews, caseq+blink_chromium.org, arv+blink, blink-reviews-style_chromium.org, vivekg_samsung, malch+blink_chromium.org, vivekg, yurys+blink_chromium.org, lushnikov+blink_chromium.org, loislo+blink_chromium.org, pfeldman+blink_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Use Local<> instead of Handle<> As v8::Handle<T> is just an alias of v8::Local<T>, making the changes in core/v8/custom/ BUG=424445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193424

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -32 lines) Patch
M Source/bindings/core/v8/custom/V8BlobCustomHelpers.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/custom/V8CustomEventCustom.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8ErrorEventCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8EventTargetCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8MessageEventCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/custom/V8WindowCustom.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M Source/bindings/core/v8/custom/V8WorkerGlobalScopeCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
deepak.s
PTAL? Thanks!
5 years, 8 months ago (2015-04-09 06:11:17 UTC) #2
deepak.s
+dominicc
5 years, 8 months ago (2015-04-09 06:13:28 UTC) #4
haraken
LGTM
5 years, 8 months ago (2015-04-09 06:15:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1074683002/1
5 years, 8 months ago (2015-04-09 06:20:32 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 07:47:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193424

Powered by Google App Engine
This is Rietveld 408576698