Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp

Issue 1074683002: [bindings] Use Local<> instead of Handle<> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp b/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp
index 802335e0736fdee832fe1e3daf74f78e979acee1..3374ee72e693b8385a34511cd418eca8c477cad3 100644
--- a/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp
@@ -41,7 +41,7 @@
namespace blink {
template<class CallbackInfo>
-static v8::Handle<v8::Value> getNamedItems(HTMLAllCollection* collection, AtomicString name, const CallbackInfo& info)
+static v8::Local<v8::Value> getNamedItems(HTMLAllCollection* collection, AtomicString name, const CallbackInfo& info)
{
WillBeHeapVector<RefPtrWillBeMember<Element>> namedItems;
collection->namedItems(name, namedItems);
@@ -67,12 +67,12 @@ static v8::Handle<v8::Value> getNamedItems(HTMLAllCollection* collection, Atomic
}
template<class CallbackInfo>
-static v8::Handle<v8::Value> getItem(HTMLAllCollection* collection, v8::Handle<v8::Value> argument, const CallbackInfo& info)
+static v8::Local<v8::Value> getItem(HTMLAllCollection* collection, v8::Local<v8::Value> argument, const CallbackInfo& info)
{
v8::Local<v8::Uint32> index;
if (!argument->ToArrayIndex(info.GetIsolate()->GetCurrentContext()).ToLocal(&index)) {
TOSTRING_DEFAULT(V8StringResource<>, name, argument, v8::Undefined(info.GetIsolate()));
- v8::Handle<v8::Value> result = getNamedItems(collection, name, info);
+ v8::Local<v8::Value> result = getNamedItems(collection, name, info);
if (result.IsEmpty())
return v8::Undefined(info.GetIsolate());
« no previous file with comments | « Source/bindings/core/v8/custom/V8EventTargetCustom.cpp ('k') | Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698