Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp - Issue 1074683002: [bindings] Use Local<> instead of Handle<>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp

Issue 1074683002: [bindings] Use Local<> instead of Handle<> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/core/v8/custom/V8MessageEventCustom.cpp ('k') | Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp b/Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp

index c3f29e09b505f4756cf364231f3c799a476946df..ee46cb95e3d63568b1419b9b3bd4df672cbc7f04 100644

--- a/Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp

@@ -58,9 +58,9 @@ void V8MutationObserver::constructorCustom(const v8::FunctionCallbackInfo<v8::Va

return;

}

- v8::Handle<v8::Object> wrapper = info.Holder();

+ v8::Local<v8::Object> wrapper = info.Holder();

- OwnPtrWillBeRawPtr<MutationCallback> callback = V8MutationCallback::create(v8::Handle<v8::Function>::Cast(arg), wrapper, ScriptState::current(info.GetIsolate()));

+ OwnPtrWillBeRawPtr<MutationCallback> callback = V8MutationCallback::create(v8::Local<v8::Function>::Cast(arg), wrapper, ScriptState::current(info.GetIsolate()));

RefPtrWillBeRawPtr<MutationObserver> observer = MutationObserver::create(callback.release());

V8DOMWrapper::associateObjectWithWrapper(info.GetIsolate(), observer.get(), &wrapperTypeInfo, wrapper);