Source/bindings/core/v8/custom/V8ErrorEventCustom.cpp - Issue 1074683002: [bindings] Use Local<> instead of Handle<>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8ErrorEventCustom.cpp

Issue 1074683002: [bindings] Use Local<> instead of Handle<> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/custom/V8ErrorEventCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8ErrorEventCustom.cpp b/Source/bindings/core/v8/custom/V8ErrorEventCustom.cpp

index ab5745bf05becf39f779679eb607b1f36182dc0a..e79fc7f97313f1c9ad6e1dc7f4b1d4eaf3d68cc7 100644

--- a/Source/bindings/core/v8/custom/V8ErrorEventCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8ErrorEventCustom.cpp

@@ -45,7 +45,7 @@ namespace blink {

void V8ErrorEvent::errorAttributeGetterCustom(const v8::PropertyCallbackInfo<v8::Value>& info)

{

- v8::Handle<v8::Value> error = V8HiddenValue::getHiddenValue(info.GetIsolate(), info.Holder(), V8HiddenValue::error(info.GetIsolate()));

+ v8::Local<v8::Value> error = V8HiddenValue::getHiddenValue(info.GetIsolate(), info.Holder(), V8HiddenValue::error(info.GetIsolate()));

if (!error.IsEmpty()) {

v8SetReturnValue(info, error);

return;