Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp

Issue 1074683002: [bindings] Use Local<> instead of Handle<> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 23 matching lines...) Expand all
34 #include "bindings/core/v8/V8Binding.h" 34 #include "bindings/core/v8/V8Binding.h"
35 #include "bindings/core/v8/V8Element.h" 35 #include "bindings/core/v8/V8Element.h"
36 #include "bindings/core/v8/V8NodeList.h" 36 #include "bindings/core/v8/V8NodeList.h"
37 #include "core/dom/StaticNodeList.h" 37 #include "core/dom/StaticNodeList.h"
38 #include "core/frame/UseCounter.h" 38 #include "core/frame/UseCounter.h"
39 #include "core/html/HTMLAllCollection.h" 39 #include "core/html/HTMLAllCollection.h"
40 40
41 namespace blink { 41 namespace blink {
42 42
43 template<class CallbackInfo> 43 template<class CallbackInfo>
44 static v8::Handle<v8::Value> getNamedItems(HTMLAllCollection* collection, Atomic String name, const CallbackInfo& info) 44 static v8::Local<v8::Value> getNamedItems(HTMLAllCollection* collection, AtomicS tring name, const CallbackInfo& info)
45 { 45 {
46 WillBeHeapVector<RefPtrWillBeMember<Element>> namedItems; 46 WillBeHeapVector<RefPtrWillBeMember<Element>> namedItems;
47 collection->namedItems(name, namedItems); 47 collection->namedItems(name, namedItems);
48 48
49 if (!namedItems.size()) 49 if (!namedItems.size())
50 return v8Undefined(); 50 return v8Undefined();
51 51
52 if (namedItems.size() == 1) 52 if (namedItems.size() == 1)
53 return toV8(namedItems.at(0).release(), info.Holder(), info.GetIsolate() ); 53 return toV8(namedItems.at(0).release(), info.Holder(), info.GetIsolate() );
54 54
55 // FIXME: HTML5 specification says this should be a HTMLCollection. 55 // FIXME: HTML5 specification says this should be a HTMLCollection.
56 // http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-in terfaces.html#htmlallcollection 56 // http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-in terfaces.html#htmlallcollection
57 // 57 //
58 // FIXME: Oilpan: explicitly convert adopt()'s result so as to 58 // FIXME: Oilpan: explicitly convert adopt()'s result so as to
59 // disambiguate the (implicit) conversion of its 59 // disambiguate the (implicit) conversion of its
60 // PassRefPtrWillBeRawPtr<StaticElementList> result -- the 60 // PassRefPtrWillBeRawPtr<StaticElementList> result -- the
61 // other toV8() overload that introduces the ambiguity is 61 // other toV8() overload that introduces the ambiguity is
62 // toV8(NodeList*, ...). 62 // toV8(NodeList*, ...).
63 // 63 //
64 // When adopt() no longer uses transition types, the conversion 64 // When adopt() no longer uses transition types, the conversion
65 // can be removed. 65 // can be removed.
66 return toV8(PassRefPtrWillBeRawPtr<NodeList>(StaticElementList::adopt(namedI tems)), info.Holder(), info.GetIsolate()); 66 return toV8(PassRefPtrWillBeRawPtr<NodeList>(StaticElementList::adopt(namedI tems)), info.Holder(), info.GetIsolate());
67 } 67 }
68 68
69 template<class CallbackInfo> 69 template<class CallbackInfo>
70 static v8::Handle<v8::Value> getItem(HTMLAllCollection* collection, v8::Handle<v 8::Value> argument, const CallbackInfo& info) 70 static v8::Local<v8::Value> getItem(HTMLAllCollection* collection, v8::Local<v8: :Value> argument, const CallbackInfo& info)
71 { 71 {
72 v8::Local<v8::Uint32> index; 72 v8::Local<v8::Uint32> index;
73 if (!argument->ToArrayIndex(info.GetIsolate()->GetCurrentContext()).ToLocal( &index)) { 73 if (!argument->ToArrayIndex(info.GetIsolate()->GetCurrentContext()).ToLocal( &index)) {
74 TOSTRING_DEFAULT(V8StringResource<>, name, argument, v8::Undefined(info. GetIsolate())); 74 TOSTRING_DEFAULT(V8StringResource<>, name, argument, v8::Undefined(info. GetIsolate()));
75 v8::Handle<v8::Value> result = getNamedItems(collection, name, info); 75 v8::Local<v8::Value> result = getNamedItems(collection, name, info);
76 76
77 if (result.IsEmpty()) 77 if (result.IsEmpty())
78 return v8::Undefined(info.GetIsolate()); 78 return v8::Undefined(info.GetIsolate());
79 79
80 return result; 80 return result;
81 } 81 }
82 82
83 RefPtrWillBeRawPtr<Element> result = collection->item(index->Uint32Value()); 83 RefPtrWillBeRawPtr<Element> result = collection->item(index->Uint32Value());
84 return toV8(result.release(), info.Holder(), info.GetIsolate()); 84 return toV8(result.release(), info.Holder(), info.GetIsolate());
85 } 85 }
(...skipping 25 matching lines...) Expand all
111 if (!info[1]->ToArrayIndex(info.GetIsolate()->GetCurrentContext()).ToLocal(& index)) 111 if (!info[1]->ToArrayIndex(info.GetIsolate()->GetCurrentContext()).ToLocal(& index))
112 return; 112 return;
113 113
114 if (Node* node = impl->namedItemWithIndex(name, index->Uint32Value())) { 114 if (Node* node = impl->namedItemWithIndex(name, index->Uint32Value())) {
115 v8SetReturnValueFast(info, node, impl); 115 v8SetReturnValueFast(info, node, impl);
116 return; 116 return;
117 } 117 }
118 } 118 }
119 119
120 } // namespace blink 120 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/custom/V8EventTargetCustom.cpp ('k') | Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698