Delete RenderBlockFlow.

Delete RenderBlockFlow.

We only ever create RenderParagraphs now. The only non-trivial change here
is making RenderView a RenderFlexibleBox. This required changing custom.sky.
That test was written in a fragile way that behaved differently if we
did multiple layouts. Instead, having it be less racy and only change
values during the test itself.

This also throws a wrench in moving all the layout code to dart
because we can't set the layout manager on the RenderView. Maybe
we need to explicitly let you do so.

R=eseidel@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/7794a09faa9b6f4d95618d74e31a0fb4d379e279

[ojan, 2015-04-07 02:25:56]

ojan@chromium.org changed reviewers:
+ eseidel@chromium.org

[eseidel, 2015-04-07 19:01:22]

Ok.  So per your explation in chat:

RenderBlock - super class for I don't know what now.
RenderBlockFlow - super class for a block containing blocks.
RenderView - root-level block flow, document's renderer
RenderParagraphFlow - block containing inlines, also subclassed RnederBlockFlow.

This just removes this uneeded super class.

lgtm

https://codereview.chromium.org/1068683002/diff/1/sky/engine/core/rendering/l...
File sky/engine/core/rendering/line/LineLayoutState.h (right):

https://codereview.chromium.org/1068683002/diff/1/sky/engine/core/rendering/l...
sky/engine/core/rendering/line/LineLayoutState.h:81:
Vector<RenderParagraph::FloatWithRect> m_floats;
Do these still exist?

[ojan, 2015-04-07 20:35:46]

> RenderBlock - super class for I don't know what now.

Yeah, it's not clear what this super class does. It's for unbreakable elements
that contain children (as opposed to RenderInline, which is breakable and
RenderReplaced, which contains no children). It should probably be renamed to
RenderContainer or something.

> RenderBlockFlow - super class for a block containing blocks.
> RenderView - root-level block flow, document's renderer
> RenderParagraphFlow - block containing inlines, also subclassed
RnederBlockFlow.

Yup. Execpt s/RenderParagraphFlow/RenderParagraph/.

https://codereview.chromium.org/1068683002/diff/1/sky/engine/core/rendering/l...
File sky/engine/core/rendering/line/LineLayoutState.h (right):

https://codereview.chromium.org/1068683002/diff/1/sky/engine/core/rendering/l...
sky/engine/core/rendering/line/LineLayoutState.h:81:
Vector<RenderParagraph::FloatWithRect> m_floats;
On 2015/04/07 19:01:22, eseidel wrote:
> Do these still exist?

They don't appear to. Will Remove.

[ojan, 2015-04-07 23:59:56]

Committed patchset #2 (id:20001) manually as
7794a09faa9b6f4d95618d74e31a0fb4d379e279 (presubmit successful).