sky/engine/core/editing/TextIterator.cpp - Issue 1068683002: Delete RenderBlockFlow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/editing/TextIterator.cpp

Issue 1068683002: Delete RenderBlockFlow. (Closed) Base URL: https://github.com/domokit/mojo.git@block

Patch Set: Remove unused float-related code instead of moving it. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/editing/TextIterator.cpp

diff --git a/sky/engine/core/editing/TextIterator.cpp b/sky/engine/core/editing/TextIterator.cpp

index fb6b87dcbc07277a5514f585d485a9e420f885c5..51113e180e959175cb261a92a473474de8684bb3 100644

--- a/sky/engine/core/editing/TextIterator.cpp

+++ b/sky/engine/core/editing/TextIterator.cpp

@@ -789,7 +789,7 @@ bool TextIterator::shouldRepresentNodeOffsetZero()

// If this node is unrendered or invisible the VisiblePosition checks below won't have much meaning.

// Additionally, if the range we are iterating over contains huge sections of unrendered content,

// we would create VisiblePositions on every call to this function without this check.

- if (!m_node->renderer() || (m_node->renderer()->isRenderBlockFlow() && !toRenderBlock(m_node->renderer())->height()))

+ if (!m_node->renderer() || (m_node->renderer()->isRenderParagraph() && !toRenderBlock(m_node->renderer())->height()))

return false;

// The startPos.isNotNull() check is needed because the start could be before the body,

« no previous file with comments | « sky/engine/core/dom/PositionIterator.cpp ('k') | sky/engine/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »