Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: sky/engine/core/dom/PositionIterator.cpp

Issue 1068683002: Delete RenderBlockFlow. (Closed) Base URL: https://github.com/domokit/mojo.git@block
Patch Set: Remove unused float-related code instead of moving it. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/Position.cpp ('k') | sky/engine/core/editing/TextIterator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/dom/PositionIterator.cpp
diff --git a/sky/engine/core/dom/PositionIterator.cpp b/sky/engine/core/dom/PositionIterator.cpp
index aef202d300e7c81e0e908094c4944d7a45fbda57..e0382583386010edc1c74b6d8170de1e726ee3ad 100644
--- a/sky/engine/core/dom/PositionIterator.cpp
+++ b/sky/engine/core/dom/PositionIterator.cpp
@@ -28,6 +28,7 @@
#include "sky/engine/core/editing/htmlediting.h"
#include "sky/engine/core/rendering/RenderBlock.h"
+#include "sky/engine/core/rendering/RenderParagraph.h"
namespace blink {
@@ -149,8 +150,8 @@ bool PositionIterator::isCandidate() const
if (editingIgnoresContent(m_anchorNode))
return (atStartOfNode() || atEndOfNode()) && !Position::nodeIsUserSelectNone(m_anchorNode->parentNode());
- if (renderer->isRenderBlockFlow()) {
- if (toRenderBlock(renderer)->logicalHeight()) {
+ if (renderer->isRenderParagraph()) {
+ if (toRenderParagraph(renderer)->logicalHeight()) {
if (!Position::hasRenderedNonAnonymousDescendantsWithHeight(renderer))
return atStartOfNode() && !Position::nodeIsUserSelectNone(m_anchorNode);
return m_anchorNode->hasEditableStyle() && !Position::nodeIsUserSelectNone(m_anchorNode) && Position(*this).atEditingBoundary();
« no previous file with comments | « sky/engine/core/dom/Position.cpp ('k') | sky/engine/core/editing/TextIterator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698