Update clang, re-enable checker, fix issues it flags

Update clang, re-enable checker, fix issues it flags

The chromium roll cc0e4f9d4e73866f10c47b46f2a369df4fd24ce9 included an
update to the clang plugin that had stricter checks for inline virtual
destructors that were incompatible with parts of the SDK. Thus the roll
disabled the checker completely with the idea it could be re-enabled
when the checker's behavior was fixed. The checker itself was fixed a
few days later but the plugin was left disabled.

This rolls to a newer clang (the one Chromium is currently using) which
includes the updated checker and fixes the things that have crept in
since the checker was disabled.

R=viettrungluu@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/de15f81b89384ee6655506fbdd0873aa9b1bf7c0

[jamesr, 2015-04-03 19:21:51]

jamesr@chromium.org changed reviewers:
+ davemoore@chromium.org, viettrungluu@chromium.org

[viettrungluu, 2015-04-03 19:45:32]

I thought that there was test headers were excluded from some checks.... :-/

https://codereview.chromium.org/1060683002/diff/1/services/files/c/lib/real_e...
File services/files/c/lib/real_errno_impl.cc (right):

https://codereview.chromium.org/1060683002/diff/1/services/files/c/lib/real_e...
services/files/c/lib/real_errno_impl.cc:12: void RealErrnoImpl::Set(int error) {
nit: blank line above

https://codereview.chromium.org/1060683002/diff/1/services/files/c/lib/real_e...
services/files/c/lib/real_errno_impl.cc:15: }
nits: blank line above and "  // namespace mojio"

https://codereview.chromium.org/1060683002/diff/1/services/files/c/lib/real_e...
File services/files/c/lib/real_errno_impl.h (right):

https://codereview.chromium.org/1060683002/diff/1/services/files/c/lib/real_e...
services/files/c/lib/real_errno_impl.h:8: #include <errno.h>
Move this include to the .cc file.

https://codereview.chromium.org/1060683002/diff/1/services/files/c/tests/fd_t...
File services/files/c/tests/fd_table_unittest.cc (right):

https://codereview.chromium.org/1060683002/diff/1/services/files/c/tests/fd_t...
services/files/c/tests/fd_table_unittest.cc:20: explicit TestFDImpl() :
FDImpl(nullptr) {}
Why the explicit?

https://codereview.chromium.org/1060683002/diff/1/services/files/c/tests/moji...
File services/files/c/tests/mojio_impl_test_base.cc (right):

https://codereview.chromium.org/1060683002/diff/1/services/files/c/tests/moji...
services/files/c/tests/mojio_impl_test_base.cc:12:
MojioImplTestBase::~MojioImplTestBase() {
nit: blank line above

https://codereview.chromium.org/1060683002/diff/1/services/files/c/tests/moji...
File services/files/c/tests/mojio_impl_test_base.h (right):

https://codereview.chromium.org/1060683002/diff/1/services/files/c/tests/moji...
services/files/c/tests/mojio_impl_test_base.h:8: #include
"mojo/public/cpp/application/application_impl.h"
Move this to the .cc file.

https://codereview.chromium.org/1060683002/diff/1/services/files/c/tests/moji...
services/files/c/tests/mojio_impl_test_base.h:10: #include
"mojo/public/cpp/bindings/interface_request.h"
"

https://codereview.chromium.org/1060683002/diff/1/services/files/c/tests/moji...
services/files/c/tests/mojio_impl_test_base.h:11: #include
"mojo/public/cpp/environment/logging.h"
"

https://codereview.chromium.org/1060683002/diff/1/services/files/c/tests/moji...
services/files/c/tests/mojio_impl_test_base.h:14: #include
"mojo/services/files/public/interfaces/files.mojom.h"
"

https://codereview.chromium.org/1060683002/diff/1/services/files/c/tests/moji...
services/files/c/tests/mojio_impl_test_base.h:15: #include
"services/files/c/lib/template_util.h"
"

https://codereview.chromium.org/1060683002/diff/1/services/files/c/tests/moji...
services/files/c/tests/mojio_impl_test_base.h:24: MojioImplTestBase();
Why isn't there an exception for test files?!

https://codereview.chromium.org/1060683002/diff/1/services/files/c/tests/moji...
File services/files/c/tests/mojio_test_base.h (right):

https://codereview.chromium.org/1060683002/diff/1/services/files/c/tests/moji...
services/files/c/tests/mojio_test_base.h:8: #include
"mojo/public/cpp/environment/logging.h"
move to .cc

https://codereview.chromium.org/1060683002/diff/1/services/files/c/tests/moji...
services/files/c/tests/mojio_test_base.h:9: #include
"services/files/c/lib/singletons.h"
"

https://codereview.chromium.org/1060683002/diff/1/services/files/files_test_b...
File services/files/files_test_base.cc (right):

https://codereview.chromium.org/1060683002/diff/1/services/files/files_test_b...
services/files/files_test_base.cc:12: FilesTestBase::~FilesTestBase() {
nit: blank line above

https://codereview.chromium.org/1060683002/diff/1/services/files/files_test_b...
File services/files/files_test_base.h (right):

https://codereview.chromium.org/1060683002/diff/1/services/files/files_test_b...
services/files/files_test_base.h:9: #include
"mojo/public/cpp/application/application_impl.h"
move to .cc

https://codereview.chromium.org/1060683002/diff/1/services/files/files_test_b...
services/files/files_test_base.h:11: #include
"mojo/services/files/public/interfaces/directory.mojom.h"
"

https://codereview.chromium.org/1060683002/diff/1/services/files/files_test_b...
services/files/files_test_base.h:13: #include
"mojo/services/files/public/interfaces/types.mojom.h"
"

[viettrungluu, 2015-04-03 19:48:23]

(also, you can take that as an lgtm w/nits, since I'm not actually working
today)

[jamesr, 2015-04-03 20:21:59]

Thanks.  Dave's also on vacation right now so I'll go ahead and land.

https://codereview.chromium.org/1060683002/diff/1/services/files/c/tests/fd_t...
File services/files/c/tests/fd_table_unittest.cc (right):

https://codereview.chromium.org/1060683002/diff/1/services/files/c/tests/fd_t...
services/files/c/tests/fd_table_unittest.cc:20: explicit TestFDImpl() :
FDImpl(nullptr) {}
On 2015/04/03 19:45:31, viettrungluu wrote:
> Why the explicit?

Brain not function well. Removed

[jamesr, 2015-04-03 20:22:23]

Committed patchset #1 (id:1) manually as
de15f81b89384ee6655506fbdd0873aa9b1bf7c0 (presubmit successful).