services/files/c/lib/real_errno_impl.h - Issue 1060683002: Update clang, re-enable checker, fix issues it flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/files/c/lib/real_errno_impl.h

Issue 1060683002: Update clang, re-enable checker, fix issues it flags (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/files/c/lib/real_errno_impl.h

diff --git a/services/files/c/lib/real_errno_impl.h b/services/files/c/lib/real_errno_impl.h

index 5f97efb1536a8dd9e5c551a264eaef5d20ea2bf0..8b698e40ffe7a20708699ffec871e00fe508579f 100644

--- a/services/files/c/lib/real_errno_impl.h

+++ b/services/files/c/lib/real_errno_impl.h

@@ -20,8 +20,8 @@ class RealErrnoImpl : public ErrnoImpl {

RealErrnoImpl() {}

~RealErrnoImpl() override {}

- int Get() const override { return errno; }

- void Set(int error) override { errno = error; }

+ int Get() const override;

+ void Set(int error) override;

private:

MOJO_DISALLOW_COPY_AND_ASSIGN(RealErrnoImpl);