Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: services/files/c/tests/mojio_test_base.h

Issue 1060683002: Update clang, re-enable checker, fix issues it flags (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/files/c/tests/mojio_test_base.h
diff --git a/services/files/c/tests/mojio_test_base.h b/services/files/c/tests/mojio_test_base.h
index 61404ab2ad16905e4b1ab28c24f7d0ab83a958ab..572fee73703daa49b4e351584a5e305d421c4022 100644
--- a/services/files/c/tests/mojio_test_base.h
+++ b/services/files/c/tests/mojio_test_base.h
@@ -19,24 +19,8 @@ class MojioTestBase : public MojioImplTestBase {
MojioTestBase() {}
~MojioTestBase() override {}
- void SetUp() override {
- MojioImplTestBase::SetUp();
-
- // Explicitly set up the singletons.
- MOJO_CHECK(singletons::GetErrnoImpl());
- MOJO_CHECK(singletons::GetFDTable());
- singletons::SetCurrentWorkingDirectory(directory().Pass());
- MOJO_CHECK(singletons::GetCurrentWorkingDirectory());
- }
-
- void TearDown() override {
- // Explicitly tear down the singletons.
- singletons::ResetCurrentWorkingDirectory();
- singletons::ResetFDTable();
- singletons::ResetErrnoImpl();
-
- MojioImplTestBase::TearDown();
- }
+ void SetUp() override;
+ void TearDown() override;
private:
MOJO_DISALLOW_COPY_AND_ASSIGN(MojioTestBase);

Powered by Google App Engine
This is Rietveld 408576698