Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: services/files/c/tests/mojio_impl_test_base.h

Issue 1060683002: Update clang, re-enable checker, fix issues it flags (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/files/c/tests/mojio_impl_test_base.h
diff --git a/services/files/c/tests/mojio_impl_test_base.h b/services/files/c/tests/mojio_impl_test_base.h
index bd2d6c8bb1e829085736f68d790b5eacc43a6692..d9ce2ff3db62eb89bc46ac11d8093a21ec8561d2 100644
--- a/services/files/c/tests/mojio_impl_test_base.h
+++ b/services/files/c/tests/mojio_impl_test_base.h
@@ -21,21 +21,10 @@ namespace test {
// doesn't use the singletons).
class MojioImplTestBase : public mojo::test::ApplicationTestBase {
public:
- MojioImplTestBase() {}
- ~MojioImplTestBase() override {}
+ MojioImplTestBase();
viettrungluu 2015/04/03 19:45:32 Why isn't there an exception for test files?!
+ ~MojioImplTestBase() override;
- void SetUp() override {
- mojo::test::ApplicationTestBase::SetUp();
-
- mojo::files::FilesPtr files;
- application_impl()->ConnectToService("mojo:files", &files);
-
- mojo::files::Error error = mojo::files::ERROR_INTERNAL;
- files->OpenFileSystem(mojo::files::FILE_SYSTEM_TEMPORARY,
- mojo::GetProxy(&directory_), Capture(&error));
- MOJO_CHECK(files.WaitForIncomingMethodCall());
- MOJO_CHECK(error == mojo::files::ERROR_OK);
- }
+ void SetUp() override;
protected:
mojo::files::DirectoryPtr& directory() { return directory_; }

Powered by Google App Engine
This is Rietveld 408576698