Update clang, re-enable checker, fix issues it flags

services/files/files_test_base.cc

Index: services/files/files_test_base.cc
diff --git a/services/files/files_test_base.cc b/services/files/files_test_base.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f46155ae16bd0bad6b303af4e78dd4e41838c993
--- /dev/null
+++ b/services/files/files_test_base.cc
@@ -0,0 +1,29 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "services/files/files_test_base.h"
+
+namespace mojo {
+namespace files {
+
+FilesTestBase::FilesTestBase() {
+}
+FilesTestBase::~FilesTestBase() {

[viettrungluu, 2015/04/03 19:45:32]

nit: blank line above

+}
+
+void FilesTestBase::SetUp() {
+  test::ApplicationTestBase::SetUp();
+  application_impl()->ConnectToService("mojo:files", &files_);
+}
+
+void FilesTestBase::GetTemporaryRoot(DirectoryPtr* directory) {
+  Error error = ERROR_INTERNAL;
+  files()->OpenFileSystem(FILE_SYSTEM_TEMPORARY, GetProxy(directory),
+                          Capture(&error));
+  ASSERT_TRUE(files().WaitForIncomingMethodCall());
+  ASSERT_EQ(ERROR_OK, error);
+}
+
+}  // namespace files
+}  // namespace mojo