Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: services/files/c/tests/fd_table_unittest.cc

Issue 1060683002: Update clang, re-enable checker, fix issues it flags (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« services/files/c/lib/real_errno_impl.cc ('K') | « services/files/c/lib/real_errno_impl.cc ('k') | services/files/c/tests/mock_errno_impl.h » ('j') | services/files/c/tests/mojio_impl_test_base.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/files/c/tests/fd_table_unittest.cc
diff --git a/services/files/c/tests/fd_table_unittest.cc b/services/files/c/tests/fd_table_unittest.cc
index 72b2db9d4f96a73e4f2611c5b61514961fd74f5b..4cc88ebb510e2c92ef3ddd231ae8eb2628e46a70 100644
--- a/services/files/c/tests/fd_table_unittest.cc
+++ b/services/files/c/tests/fd_table_unittest.cc
@@ -17,8 +17,8 @@ namespace {
class TestFDImpl : public FDImpl {
public:
- TestFDImpl() : FDImpl(nullptr) {}
- virtual ~TestFDImpl() {}
+ explicit TestFDImpl() : FDImpl(nullptr) {}
viettrungluu 2015/04/03 19:45:31 Why the explicit?
jamesr 2015/04/03 20:21:58 Brain not function well. Removed
+ ~TestFDImpl() override {}
// |FDImpl| implementation:
bool Close() override { return false; }
« services/files/c/lib/real_errno_impl.cc ('K') | « services/files/c/lib/real_errno_impl.cc ('k') | services/files/c/tests/mock_errno_impl.h » ('j') | services/files/c/tests/mojio_impl_test_base.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698