mojo/tools/roll/disable_find_bad_constructs.patch - Issue 1060683002: Update clang, re-enable checker, fix issues it flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/tools/roll/disable_find_bad_constructs.patch

Issue 1060683002: Update clang, re-enable checker, fix issues it flags (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/tools/roll/disable_find_bad_constructs.patch

diff --git a/mojo/tools/roll/disable_find_bad_constructs.patch b/mojo/tools/roll/disable_find_bad_constructs.patch

deleted file mode 100644

index 4549e5bee060c3aed6950880ef3c94eb7e64eec3..0000000000000000000000000000000000000000

--- a/mojo/tools/roll/disable_find_bad_constructs.patch

+++ /dev/null

@@ -1,18 +0,0 @@

-diff --git a/build/config/clang/BUILD.gn b/build/config/clang/BUILD.gn

-index 39fe251..721e87c 100644

---- a/build/config/clang/BUILD.gn

-+++ b/build/config/clang/BUILD.gn

-@@ -21,13 +21,6 @@ config("find_bad_constructs") {

- "//third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so",

- root_build_dir) ]

- }

-- cflags += [

-- "-Xclang",

-- "-add-plugin",

-- "-Xclang",

-- "find-bad-constructs",

-- ]

- }