Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 102163002: Revert 238283 "Infobar system refactor." (Closed)

Created:
7 years ago by tonyg
Modified:
7 years ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 238283 "Infobar system refactor." Crashes on android BUG=325216 > Infobar system refactor. > > This changes the ownership model of infobars so that InfoBars are long-lived and > own their InfoBarDelegates directly. The InfoBarService pseudo-owns the > InfoBars (instead of deleting them directly, it tells them when they're unowned > and expects them to delete themselves). > > This fixes leaks when infobars are closed while not visible (e.g. in a > background tab) and in general makes the system clearer and easier to reason > about. > > BUG=62154 > TEST=none > R=erg@chromium.org, sail@chromium.org, sky@chromium.org > > Review URL: https://codereview.chromium.org/22694006 TBR=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1471 lines, -1248 lines) Patch
M trunk/src/chrome/browser/accessibility/accessibility_extension_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/autofill/autofill_browsertest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/autofill/autofill_cc_infobar_delegate.h View 2 chunks +5 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/autofill/autofill_cc_infobar_delegate.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/autofill/autofill_interactive_uitest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/automation/testing_automation_provider.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/chrome_quota_permission_context.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/content_settings/permission_queue_controller.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/content_settings/permission_queue_controller_unittest.cc View 3 chunks +26 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.h View 1 chunk +5 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/devtools/devtools_window.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/download/download_browsertest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/download/download_request_infobar_delegate.h View 2 chunks +3 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/download/download_request_infobar_delegate.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/debugger/debugger_api.cc View 10 chunks +24 lines, -18 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_infobar_delegate.h View 3 chunks +21 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_infobar_delegate.cc View 4 chunks +21 lines, -11 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_install_ui_browsertest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.h View 1 chunk +4 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/extensions/theme_installed_infobar_delegate.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc View 21 chunks +65 lines, -59 lines 0 comments Download
M trunk/src/chrome/browser/geolocation/geolocation_browsertest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/geolocation/geolocation_infobar_delegate.h View 1 chunk +9 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/geolocation/geolocation_infobar_delegate.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/geolocation/geolocation_infobar_delegate_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/geolocation/geolocation_infobar_delegate_android.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/google/google_url_tracker.h View 2 chunks +7 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/google/google_url_tracker.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/google/google_url_tracker_infobar_delegate.h View 2 chunks +8 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/google/google_url_tracker_infobar_delegate.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/google/google_url_tracker_map_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/google/google_url_tracker_unittest.cc View 8 chunks +28 lines, -27 lines 0 comments Download
M trunk/src/chrome/browser/infobars/confirm_infobar_delegate.h View 2 chunks +4 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/infobars/confirm_infobar_delegate.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/infobars/infobar.h View 6 chunks +22 lines, -43 lines 0 comments Download
M trunk/src/chrome/browser/infobars/infobar.cc View 6 chunks +20 lines, -19 lines 0 comments Download
M trunk/src/chrome/browser/infobars/infobar_container.h View 5 chunks +21 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/infobars/infobar_container.cc View 3 chunks +41 lines, -15 lines 0 comments Download
M trunk/src/chrome/browser/infobars/infobar_delegate.h View 2 chunks +27 lines, -17 lines 0 comments Download
M trunk/src/chrome/browser/infobars/infobar_delegate.cc View 3 chunks +15 lines, -12 lines 0 comments Download
M trunk/src/chrome/browser/infobars/infobar_service.h View 5 chunks +23 lines, -27 lines 0 comments Download
M trunk/src/chrome/browser/infobars/infobar_service.cc View 6 chunks +25 lines, -22 lines 0 comments Download
M trunk/src/chrome/browser/infobars/insecure_content_infobar_delegate.h View 2 chunks +3 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/infobars/insecure_content_infobar_delegate.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/infobars/simple_alert_infobar_delegate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/infobars/simple_alert_infobar_delegate.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/managed_mode/managed_mode_interstitial.cc View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/managed_mode/managed_mode_navigation_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/managed_mode/managed_mode_navigation_observer.cc View 3 chunks +10 lines, -11 lines 0 comments Download
M trunk/src/chrome/browser/media/media_stream_infobar_delegate.h View 2 chunks +6 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/media/media_stream_infobar_delegate.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/media/midi_permission_infobar_delegate.h View 1 chunk +9 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/media/midi_permission_infobar_delegate.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/media/protected_media_identifier_infobar_delegate.h View 1 chunk +9 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/media/protected_media_identifier_infobar_delegate.cc View 3 chunks +13 lines, -14 lines 0 comments Download
M trunk/src/chrome/browser/media/webrtc_browsertest_base.h View 2 chunks +6 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/media/webrtc_browsertest_base.cc View 7 chunks +16 lines, -12 lines 0 comments Download
M trunk/src/chrome/browser/nacl_host/nacl_infobar_delegate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/nacl_host/nacl_infobar_delegate.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/notifications/desktop_notification_service.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/notifications/notification_browsertest.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/password_manager/password_manager_browsertest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M trunk/src/chrome/browser/password_manager/password_manager_delegate_impl.cc View 4 chunks +14 lines, -12 lines 0 comments Download
M trunk/src/chrome/browser/pepper_broker_infobar_delegate.h View 1 chunk +4 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/pepper_broker_infobar_delegate.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/plugins/plugin_infobar_delegates.h View 6 chunks +15 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/plugins/plugin_infobar_delegates.cc View 11 chunks +40 lines, -36 lines 0 comments Download
M trunk/src/chrome/browser/policy/policy_browsertest.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/ssl/ssl_tab_helper.cc View 3 chunks +17 lines, -15 lines 0 comments Download
M trunk/src/chrome/browser/task_manager/task_manager_browsertest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/three_d_api_observer.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/translate/options_menu_model.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/translate/translate_browsertest.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/translate/translate_infobar_delegate.h View 3 chunks +4 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/translate/translate_infobar_delegate.cc View 10 chunks +14 lines, -19 lines 0 comments Download
M trunk/src/chrome/browser/translate/translate_manager_browsertest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.h View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.cc View 4 chunks +12 lines, -11 lines 0 comments Download
M trunk/src/chrome/browser/ui/android/infobars/auto_login_infobar_delegate_android.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/android/infobars/auto_login_infobar_delegate_android.cc View 3 chunks +12 lines, -11 lines 0 comments Download
M trunk/src/chrome/browser/ui/android/infobars/confirm_infobar.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/android/infobars/confirm_infobar.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/ui/android/infobars/infobar_android.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/android/infobars/infobar_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/android/infobars/infobar_container_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/android/infobars/translate_infobar.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/android/infobars/translate_infobar.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/apps/app_metro_infobar_delegate_win.h View 1 chunk +5 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/apps/app_metro_infobar_delegate_win.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/auto_login_infobar_delegate.h View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/auto_login_infobar_delegate.cc View 3 chunks +12 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm View 1 chunk +3 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm View 1 chunk +3 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/infobars/confirm_infobar_controller_unittest.mm View 7 chunks +30 lines, -35 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/infobars/extension_infobar_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm View 6 chunks +35 lines, -30 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/infobars/infobar_cocoa.h View 2 chunks +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/infobars/infobar_cocoa.mm View 2 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm View 2 chunks +6 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/infobars/infobar_container_controller_unittest.mm View 2 chunks +8 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/infobars/infobar_controller.h View 2 chunks +2 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/infobars/infobar_controller.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/infobars/mock_confirm_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm View 4 chunks +10 lines, -14 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm View 9 chunks +35 lines, -44 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/keystone_infobar_delegate.mm View 3 chunks +8 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/collected_cookies_infobar_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/collected_cookies_infobar_delegate.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/content_settings/media_setting_changed_infobar_delegate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/content_settings/media_setting_changed_infobar_delegate.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/extensions/extension_install_ui_default.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/infobars/after_translate_infobar_gtk.h View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/infobars/after_translate_infobar_gtk.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/infobars/alternate_nav_infobar_gtk.h View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/infobars/alternate_nav_infobar_gtk.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/infobars/before_translate_infobar_gtk.h View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/infobars/before_translate_infobar_gtk.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/infobars/confirm_infobar_gtk.h View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/infobars/confirm_infobar_gtk.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/infobars/extension_infobar_gtk.h View 2 chunks +14 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc View 3 chunks +34 lines, -27 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/infobars/infobar_container_gtk.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/infobars/infobar_gtk.h View 2 chunks +13 lines, -11 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/infobars/infobar_gtk.cc View 4 chunks +29 lines, -29 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/infobars/translate_infobar_base_gtk.h View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/infobars/translate_infobar_base_gtk.cc View 4 chunks +28 lines, -31 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/infobars/translate_message_infobar_gtk.h View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/infobars/translate_message_infobar_gtk.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/hung_plugin_tab_helper.cc View 4 chunks +26 lines, -16 lines 0 comments Download
M trunk/src/chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.h View 2 chunks +8 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc View 4 chunks +8 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/ui/startup/autolaunch_prompt_win.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/ui/startup/default_browser_prompt.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/ui/startup/google_api_keys_infobar_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/startup/google_api_keys_infobar_delegate.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/ui/startup/obsolete_os_infobar_delegate.h View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/startup/obsolete_os_infobar_delegate.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/ui/startup/session_crashed_infobar_delegate.h View 2 chunks +23 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/startup/session_crashed_infobar_delegate.cc View 5 chunks +34 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/infobars/after_translate_infobar.h View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/views/infobars/after_translate_infobar.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/infobars/alternate_nav_infobar_view.h View 2 chunks +4 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/infobars/alternate_nav_infobar_view.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/infobars/before_translate_infobar.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/infobars/before_translate_infobar.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/infobars/confirm_infobar.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/views/infobars/confirm_infobar.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/infobars/extension_infobar.h View 4 chunks +12 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/infobars/extension_infobar.cc View 4 chunks +16 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/infobars/infobar_container_view.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/infobars/infobar_view.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/views/infobars/infobar_view.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/infobars/translate_infobar_base.h View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/views/infobars/translate_infobar_base.cc View 3 chunks +9 lines, -12 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/infobars/translate_message_infobar.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/infobars/translate_message_infobar.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/website_settings/website_settings_infobar_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/website_settings/website_settings_infobar_delegate.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/website_settings/website_settings_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M trunk/src/chrome/test/gpu/webgl_infobar_browsertest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/chrome/test/ppapi/ppapi_test.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/src/tools/valgrind/memcheck/suppressions.txt View 4 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tonyg
7 years ago (2013-12-03 15:37:27 UTC) #1
tonyg
7 years ago (2013-12-03 15:39:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r238402.

Powered by Google App Engine
This is Rietveld 408576698