Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: trunk/src/chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc

Issue 102163002: Revert 238283 "Infobar system refactor." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/startup/session_crashed_infobar_delegate.h" 5 #include "chrome/browser/ui/startup/session_crashed_infobar_delegate.h"
6 6
7 #include "base/prefs/pref_registry_simple.h" 7 #include "base/prefs/pref_registry_simple.h"
8 #include "base/prefs/testing_pref_service.h" 8 #include "base/prefs/testing_pref_service.h"
9 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "chrome/browser/infobars/infobar.h"
11 #include "chrome/browser/infobars/infobar_service.h" 10 #include "chrome/browser/infobars/infobar_service.h"
12 #include "chrome/browser/sessions/session_service_factory.h" 11 #include "chrome/browser/sessions/session_service_factory.h"
13 #include "chrome/browser/ui/tabs/tab_strip_model.h" 12 #include "chrome/browser/ui/tabs/tab_strip_model.h"
14 #include "chrome/common/pref_names.h" 13 #include "chrome/common/pref_names.h"
15 #include "chrome/common/url_constants.h" 14 #include "chrome/common/url_constants.h"
16 #include "chrome/test/base/browser_with_test_window_test.h" 15 #include "chrome/test/base/browser_with_test_window_test.h"
17 #include "chrome/test/base/scoped_testing_local_state.h" 16 #include "chrome/test/base/scoped_testing_local_state.h"
18 #include "chrome/test/base/testing_browser_process.h" 17 #include "chrome/test/base/testing_browser_process.h"
19 18
20 class SessionCrashedInfoBarDelegateUnitTest : public BrowserWithTestWindowTest { 19 class SessionCrashedInfoBarDelegateUnitTest : public BrowserWithTestWindowTest {
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 54
56 // Attach the crashed infobar to it. 55 // Attach the crashed infobar to it.
57 SessionCrashedInfoBarDelegate::Create(first_browser.get()); 56 SessionCrashedInfoBarDelegate::Create(first_browser.get());
58 57
59 TabStripModel* tab_strip = first_browser->tab_strip_model(); 58 TabStripModel* tab_strip = first_browser->tab_strip_model();
60 ASSERT_EQ(1, tab_strip->count()); 59 ASSERT_EQ(1, tab_strip->count());
61 content::WebContents* web_contents = tab_strip->GetWebContentsAt(0); 60 content::WebContents* web_contents = tab_strip->GetWebContentsAt(0);
62 InfoBarService* infobar_service = 61 InfoBarService* infobar_service =
63 InfoBarService::FromWebContents(web_contents); 62 InfoBarService::FromWebContents(web_contents);
64 EXPECT_EQ(1U, infobar_service->infobar_count()); 63 EXPECT_EQ(1U, infobar_service->infobar_count());
65 ConfirmInfoBarDelegate* infobar = 64 scoped_ptr<ConfirmInfoBarDelegate> infobar(InfoBarService::FromWebContents(
66 infobar_service->infobar_at(0)->delegate()->AsConfirmInfoBarDelegate(); 65 web_contents)->infobar_at(0)->AsConfirmInfoBarDelegate());
67 ASSERT_TRUE(infobar); 66 ASSERT_TRUE(infobar);
68 67
69 // Open another browser. 68 // Open another browser.
70 scoped_ptr<Browser> opened_browser( 69 scoped_ptr<Browser> opened_browser(
71 chrome::CreateBrowserWithTestWindowForParams(&params)); 70 chrome::CreateBrowserWithTestWindowForParams(&params));
72 71
73 // Move the tab which is destroying the crash info bar to the new browser. 72 // Move the tab which is destroying the crash info bar to the new browser.
74 tab_strip->DetachWebContentsAt(0); 73 tab_strip->DetachWebContentsAt(0);
75 tab_strip = opened_browser->tab_strip_model(); 74 tab_strip = opened_browser->tab_strip_model();
76 tab_strip->AppendWebContents(web_contents, true); 75 tab_strip->AppendWebContents(web_contents, true);
77 76
78 // Close the original browser. 77 // Close the original browser.
79 first_browser->window()->Close(); 78 first_browser->window()->Close();
80 first_browser.reset(); 79 first_browser.reset();
81 80
82 ASSERT_EQ(1, tab_strip->count()); 81 ASSERT_EQ(1, tab_strip->count());
83 web_contents = tab_strip->GetWebContentsAt(0); 82 web_contents = tab_strip->GetWebContentsAt(0);
84 infobar_service = InfoBarService::FromWebContents(web_contents); 83 infobar_service = InfoBarService::FromWebContents(web_contents);
85 EXPECT_EQ(1U, infobar_service->infobar_count()); 84 EXPECT_EQ(1U, infobar_service->infobar_count());
86 85
87 // This used to crash. 86 // This used to crash.
88 infobar->Accept(); 87 infobar->Accept();
89 88
90 // Ramp down the test. 89 // Ramp down the test.
91 tab_strip->CloseWebContentsAt(0, TabStripModel::CLOSE_NONE); 90 tab_strip->CloseWebContentsAt(0, TabStripModel::CLOSE_NONE);
92 } 91 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698