Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: trunk/src/chrome/browser/extensions/api/debugger/debugger_api.cc

Issue 102163002: Revert 238283 "Infobar system refactor." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/extensions/api/debugger/debugger_api.cc
===================================================================
--- trunk/src/chrome/browser/extensions/api/debugger/debugger_api.cc (revision 238401)
+++ trunk/src/chrome/browser/extensions/api/debugger/debugger_api.cc (working copy)
@@ -66,7 +66,11 @@
namespace OnEvent = extensions::api::debugger::OnEvent;
namespace SendCommand = extensions::api::debugger::SendCommand;
+namespace {
+class ExtensionDevToolsInfoBarDelegate;
+} // namespace
+
// ExtensionDevToolsClientHost ------------------------------------------------
class ExtensionDevToolsClientHost : public DevToolsClientHost,
@@ -78,7 +82,7 @@
const std::string& extension_id,
const std::string& extension_name,
const Debuggee& debuggee,
- InfoBar* infobar);
+ ExtensionDevToolsInfoBarDelegate* infobar);
virtual ~ExtensionDevToolsClientHost();
@@ -113,7 +117,7 @@
typedef std::map<int, scoped_refptr<DebuggerSendCommandFunction> >
PendingRequests;
PendingRequests pending_requests_;
- InfoBar* infobar_;
+ ExtensionDevToolsInfoBarDelegate* infobar_;
OnDetach::Reason detach_reason_;
DISALLOW_COPY_AND_ASSIGN(ExtensionDevToolsClientHost);
@@ -141,17 +145,20 @@
class ExtensionDevToolsInfoBarDelegate : public ConfirmInfoBarDelegate {
public:
- // Creates an extension dev tools infobar and delegate and adds the infobar to
- // the InfoBarService associated with |rvh|. Returns the infobar if it was
+ // Creates an extension dev tools infobar delegate and adds it to the
+ // InfoBarService associated with |rvh|. Returns the delegate if it was
// successfully added.
- static InfoBar* Create(RenderViewHost* rvh, const std::string& client_name);
+ static ExtensionDevToolsInfoBarDelegate* Create(
+ RenderViewHost* rvh,
+ const std::string& client_name);
void set_client_host(ExtensionDevToolsClientHost* client_host) {
client_host_ = client_host;
}
private:
- explicit ExtensionDevToolsInfoBarDelegate(const std::string& client_name);
+ ExtensionDevToolsInfoBarDelegate(InfoBarService* infobar_service,
+ const std::string& client_name);
virtual ~ExtensionDevToolsInfoBarDelegate();
// ConfirmInfoBarDelegate:
@@ -170,7 +177,7 @@
};
// static
-InfoBar* ExtensionDevToolsInfoBarDelegate::Create(
+ExtensionDevToolsInfoBarDelegate* ExtensionDevToolsInfoBarDelegate::Create(
RenderViewHost* rvh,
const std::string& client_name) {
if (!rvh)
@@ -185,14 +192,15 @@
if (!infobar_service)
return NULL;
- return infobar_service->AddInfoBar(ConfirmInfoBarDelegate::CreateInfoBar(
- scoped_ptr<ConfirmInfoBarDelegate>(
- new ExtensionDevToolsInfoBarDelegate(client_name))));
+ return static_cast<ExtensionDevToolsInfoBarDelegate*>(
+ infobar_service->AddInfoBar(scoped_ptr<InfoBarDelegate>(
+ new ExtensionDevToolsInfoBarDelegate(infobar_service, client_name))));
}
ExtensionDevToolsInfoBarDelegate::ExtensionDevToolsInfoBarDelegate(
+ InfoBarService* infobar_service,
const std::string& client_name)
- : ConfirmInfoBarDelegate(),
+ : ConfirmInfoBarDelegate(infobar_service),
client_name_(client_name),
client_host_(NULL) {
}
@@ -295,7 +303,7 @@
const std::string& extension_id,
const std::string& extension_name,
const Debuggee& debuggee,
- InfoBar* infobar)
+ ExtensionDevToolsInfoBarDelegate* infobar)
: profile_(profile),
agent_host_(agent_host),
extension_id_(extension_id),
@@ -321,8 +329,7 @@
agent_host_.get(), this);
if (infobar_) {
- static_cast<ExtensionDevToolsInfoBarDelegate*>(
- infobar_->delegate())->set_client_host(this);
+ infobar_->set_client_host(this);
registrar_.Add(
this, chrome::NOTIFICATION_TAB_CONTENTS_INFOBAR_REMOVED,
content::Source<InfoBarService>(InfoBarService::FromWebContents(
@@ -337,8 +344,7 @@
registrar_.RemoveAll();
if (infobar_) {
- static_cast<ExtensionDevToolsInfoBarDelegate*>(
- infobar_->delegate())->set_client_host(NULL);
+ infobar_->set_client_host(NULL);
InfoBarService::FromWebContents(WebContents::FromRenderViewHost(
agent_host_->GetRenderViewHost()))->RemoveInfoBar(infobar_);
}
@@ -563,13 +569,13 @@
return false;
}
- InfoBar* infobar = NULL;
+ ExtensionDevToolsInfoBarDelegate* infobar = NULL;
if (!CommandLine::ForCurrentProcess()->
HasSwitch(switches::kSilentDebuggerExtensionAPI)) {
// Do not attach to the target if for any reason the infobar cannot be shown
// for this WebContents instance.
infobar = ExtensionDevToolsInfoBarDelegate::Create(
- agent_host_->GetRenderViewHost(), GetExtension()->name());
+ agent_host_->GetRenderViewHost(), GetExtension()->name());
if (!infobar) {
error_ = ErrorUtils::FormatErrorMessage(
keys::kSilentDebuggingRequired,

Powered by Google App Engine
This is Rietveld 408576698