Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: trunk/src/chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm

Issue 102163002: Revert 238283 "Infobar system refactor." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm
===================================================================
--- trunk/src/chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm (revision 238401)
+++ trunk/src/chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm (working copy)
@@ -6,6 +6,7 @@
#include "base/logging.h"
#include "base/mac/mac_util.h"
+#include "base/message_loop/message_loop.h"
#include "chrome/browser/infobars/confirm_infobar_delegate.h"
#include "chrome/browser/infobars/infobar.h"
#include "chrome/browser/infobars/infobar_container.h"
@@ -99,8 +100,11 @@
}
- (void)removeInfoBar:(InfoBarCocoa*)infobar {
- [infobar->controller() infobarWillHide];
- [self removeController:infobar->controller()];
+ InfoBarController* controller = infobar->controller();
+ [controller infobarWillClose];
+ infobar->set_controller(nil);
+ [self removeController:controller];
+ base::MessageLoop::current()->DeleteSoon(FROM_HERE, infobar);
}
- (void)positionInfoBarsAndRedraw:(BOOL)isAnimating {

Powered by Google App Engine
This is Rietveld 408576698