Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: trunk/src/chrome/browser/ui/views/infobars/translate_infobar_base.cc

Issue 102163002: Revert 238283 "Infobar system refactor." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/ui/views/infobars/translate_infobar_base.cc
===================================================================
--- trunk/src/chrome/browser/ui/views/infobars/translate_infobar_base.cc (revision 238401)
+++ trunk/src/chrome/browser/ui/views/infobars/translate_infobar_base.cc (working copy)
@@ -5,7 +5,6 @@
#include "chrome/browser/ui/views/infobars/translate_infobar_base.h"
#include "base/strings/utf_string_conversions.h"
-#include "chrome/browser/infobars/infobar.h"
#include "chrome/browser/translate/translate_infobar_delegate.h"
#include "chrome/browser/ui/views/infobars/after_translate_infobar.h"
#include "chrome/browser/ui/views/infobars/before_translate_infobar.h"
@@ -20,14 +19,12 @@
// TranslateInfoBarDelegate ---------------------------------------------------
-// static
-scoped_ptr<InfoBar> TranslateInfoBarDelegate::CreateInfoBar(
- scoped_ptr<TranslateInfoBarDelegate> delegate) {
- if (delegate->infobar_type() == BEFORE_TRANSLATE)
- return scoped_ptr<InfoBar>(new BeforeTranslateInfoBar(delegate.Pass()));
- if (delegate->infobar_type() == AFTER_TRANSLATE)
- return scoped_ptr<InfoBar>(new AfterTranslateInfoBar(delegate.Pass()));
- return scoped_ptr<InfoBar>(new TranslateMessageInfoBar(delegate.Pass()));
+InfoBar* TranslateInfoBarDelegate::CreateInfoBar(InfoBarService* owner) {
+ if (infobar_type_ == BEFORE_TRANSLATE)
+ return new BeforeTranslateInfoBar(owner, this);
+ if (infobar_type_ == AFTER_TRANSLATE)
+ return new AfterTranslateInfoBar(owner, this);
+ return new TranslateMessageInfoBar(owner, this);
}
@@ -45,9 +42,9 @@
SchedulePaint();
}
-TranslateInfoBarBase::TranslateInfoBarBase(
- scoped_ptr<TranslateInfoBarDelegate> delegate)
- : InfoBarView(delegate.PassAs<InfoBarDelegate>()),
+TranslateInfoBarBase::TranslateInfoBarBase(InfoBarService* owner,
+ TranslateInfoBarDelegate* delegate)
+ : InfoBarView(owner, delegate),
error_background_(InfoBarDelegate::WARNING_TYPE) {
}

Powered by Google App Engine
This is Rietveld 408576698