Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: trunk/src/chrome/browser/notifications/desktop_notification_service.cc

Issue 102163002: Revert 238283 "Infobar system refactor." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/notifications/desktop_notification_service.cc
===================================================================
--- trunk/src/chrome/browser/notifications/desktop_notification_service.cc (revision 238401)
+++ trunk/src/chrome/browser/notifications/desktop_notification_service.cc (working copy)
@@ -17,7 +17,6 @@
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_system.h"
#include "chrome/browser/infobars/confirm_infobar_delegate.h"
-#include "chrome/browser/infobars/infobar.h"
#include "chrome/browser/infobars/infobar_service.h"
#include "chrome/browser/notifications/desktop_notification_service_factory.h"
#include "chrome/browser/notifications/notification.h"
@@ -68,8 +67,8 @@
// permissions.
class NotificationPermissionInfoBarDelegate : public ConfirmInfoBarDelegate {
public:
- // Creates a notification permission infobar and delegate and adds the infobar
- // to |infobar_service|.
+ // Creates a notification permission infobar delegate and adds it to
+ // |infobar_service|.
static void Create(InfoBarService* infobar_service,
DesktopNotificationService* notification_service,
const GURL& origin,
@@ -80,6 +79,7 @@
private:
NotificationPermissionInfoBarDelegate(
+ InfoBarService* infobar_service,
DesktopNotificationService* notification_service,
const GURL& origin,
const string16& display_name,
@@ -127,21 +127,21 @@
int process_id,
int route_id,
int callback_context) {
- infobar_service->AddInfoBar(ConfirmInfoBarDelegate::CreateInfoBar(
- scoped_ptr<ConfirmInfoBarDelegate>(
- new NotificationPermissionInfoBarDelegate(
- notification_service, origin, display_name, process_id, route_id,
- callback_context))));
+ infobar_service->AddInfoBar(scoped_ptr<InfoBarDelegate>(
+ new NotificationPermissionInfoBarDelegate(
+ infobar_service, notification_service, origin, display_name,
+ process_id, route_id, callback_context)));
}
NotificationPermissionInfoBarDelegate::NotificationPermissionInfoBarDelegate(
+ InfoBarService* infobar_service,
DesktopNotificationService* notification_service,
const GURL& origin,
const string16& display_name,
int process_id,
int route_id,
int callback_context)
- : ConfirmInfoBarDelegate(),
+ : ConfirmInfoBarDelegate(infobar_service),
origin_(origin),
display_name_(display_name),
notification_service_(notification_service),

Powered by Google App Engine
This is Rietveld 408576698