Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: trunk/src/chrome/browser/ui/views/infobars/extension_infobar.cc

Issue 102163002: Revert 238283 "Infobar system refactor." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/ui/views/infobars/extension_infobar.cc
===================================================================
--- trunk/src/chrome/browser/ui/views/infobars/extension_infobar.cc (revision 238401)
+++ trunk/src/chrome/browser/ui/views/infobars/extension_infobar.cc (working copy)
@@ -29,11 +29,8 @@
// ExtensionInfoBarDelegate ----------------------------------------------------
-// static
-scoped_ptr<InfoBar> ExtensionInfoBarDelegate::CreateInfoBar(
- scoped_ptr<ExtensionInfoBarDelegate> delegate) {
- Browser* browser = delegate->browser_;
- return scoped_ptr<InfoBar>(new ExtensionInfoBar(delegate.Pass(), browser));
+InfoBar* ExtensionInfoBarDelegate::CreateInfoBar(InfoBarService* owner) {
+ return new ExtensionInfoBar(owner, this, browser_);
}
@@ -81,20 +78,25 @@
} // namespace
-ExtensionInfoBar::ExtensionInfoBar(
- scoped_ptr<ExtensionInfoBarDelegate> delegate,
- Browser* browser)
- : InfoBarView(delegate.PassAs<InfoBarDelegate>()),
+ExtensionInfoBar::ExtensionInfoBar(InfoBarService* owner,
+ ExtensionInfoBarDelegate* delegate,
+ Browser* browser)
+ : InfoBarView(owner, delegate),
+ delegate_(delegate),
browser_(browser),
infobar_icon_(NULL),
icon_as_menu_(NULL),
icon_as_image_(NULL),
weak_ptr_factory_(this) {
+ GetDelegate()->set_observer(this);
+
int height = GetDelegate()->height();
SetBarTargetHeight((height > 0) ? (height + kSeparatorLineHeight) : 0);
}
ExtensionInfoBar::~ExtensionInfoBar() {
+ if (GetDelegate())
+ GetDelegate()->set_observer(NULL);
}
void ExtensionInfoBar::Layout() {
@@ -164,6 +166,10 @@
}
+void ExtensionInfoBar::OnDelegateDeleted() {
+ delegate_ = NULL;
+}
+
void ExtensionInfoBar::OnMenuButtonClicked(views::View* source,
const gfx::Point& point) {
if (!owner())
@@ -209,5 +215,5 @@
}
ExtensionInfoBarDelegate* ExtensionInfoBar::GetDelegate() {
- return delegate()->AsExtensionInfoBarDelegate();
+ return delegate_ ? delegate_->AsExtensionInfoBarDelegate() : NULL;
}

Powered by Google App Engine
This is Rietveld 408576698