Issue 517343002: Ensure that BoxInt32 input is correctly preserved on the slow-path.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 517343002: Ensure that BoxInt32 input is correctly preserved on the slow-path. (Closed)

Created:
6 years, 3 months ago by Vyacheslav Egorov (Google)

Modified:
6 years, 3 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Ensure that BoxInt32 input is correctly preserved on the slow-path. Register allocator is unable to preserve writable registers automatically because they behave like temps: have no fixed represenation or usage inside the instruction template. This means writable registers have to be manually added with the right representation to the live_register set when necessary. Add verification that checks this and fix existing misuses. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=39703

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+100 lines, -0 lines)			Patch
M	runtime/vm/flow_graph_allocator.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/locations.h	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/locations.cc	View	2 chunks	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

6 years, 3 months ago (2014-08-29 15:20:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 39703 (presubmit successful).

Expand Messages | Collapse Messages