Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Side by Side Diff: runtime/vm/intermediate_language_arm64.cc

Issue 517343002: Ensure that BoxInt32 input is correctly preserved on the slow-path. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64.
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 1726 matching lines...) Expand 10 before | Expand all | Expand 10 after
1737 } 1737 }
1738 1738
1739 return; 1739 return;
1740 } 1740 }
1741 1741
1742 if (IsPotentialUnboxedStore()) { 1742 if (IsPotentialUnboxedStore()) {
1743 const Register value_reg = locs()->in(1).reg(); 1743 const Register value_reg = locs()->in(1).reg();
1744 const Register temp = locs()->temp(0).reg(); 1744 const Register temp = locs()->temp(0).reg();
1745 const Register temp2 = locs()->temp(1).reg(); 1745 const Register temp2 = locs()->temp(1).reg();
1746 1746
1747 if (ShouldEmitStoreBarrier()) {
1748 // Value input is a writable register and should be manually preserved
1749 // across allocation slow-path.
1750 locs()->live_registers()->Add(locs()->in(1), kTagged);
1751 }
1752
1747 Label store_pointer; 1753 Label store_pointer;
1748 Label store_double; 1754 Label store_double;
1749 Label store_float32x4; 1755 Label store_float32x4;
1750 Label store_float64x2; 1756 Label store_float64x2;
1751 1757
1752 __ LoadObject(temp, Field::ZoneHandle(field().raw()), PP); 1758 __ LoadObject(temp, Field::ZoneHandle(field().raw()), PP);
1753 1759
1754 __ LoadFieldFromOffset(temp2, temp, Field::is_nullable_offset(), PP, kWord); 1760 __ LoadFieldFromOffset(temp2, temp, Field::is_nullable_offset(), PP, kWord);
1755 __ CompareImmediate(temp2, kNullCid, PP); 1761 __ CompareImmediate(temp2, kNullCid, PP);
1756 __ b(&store_pointer, EQ); 1762 __ b(&store_pointer, EQ);
(...skipping 3664 matching lines...) Expand 10 before | Expand all | Expand 10 after
5421 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs()); 5427 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs());
5422 #if defined(DEBUG) 5428 #if defined(DEBUG)
5423 __ LoadImmediate(R4, kInvalidObjectPointer, kNoPP); 5429 __ LoadImmediate(R4, kInvalidObjectPointer, kNoPP);
5424 __ LoadImmediate(R5, kInvalidObjectPointer, kNoPP); 5430 __ LoadImmediate(R5, kInvalidObjectPointer, kNoPP);
5425 #endif 5431 #endif
5426 } 5432 }
5427 5433
5428 } // namespace dart 5434 } // namespace dart
5429 5435
5430 #endif // defined TARGET_ARCH_ARM64 5436 #endif // defined TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698