Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Side by Side Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 517343002: Ensure that BoxInt32 input is correctly preserved on the slow-path. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 1389 matching lines...) Expand 10 before | Expand all | Expand 10 after
1400 __ popl(left); 1400 __ popl(left);
1401 } else { 1401 } else {
1402 __ cmpl(left, right); 1402 __ cmpl(left, right);
1403 } 1403 }
1404 } 1404 }
1405 1405
1406 1406
1407 // This function must be in sync with FlowGraphCompiler::RecordSafepoint and 1407 // This function must be in sync with FlowGraphCompiler::RecordSafepoint and
1408 // FlowGraphCompiler::SlowPathEnvironmentFor. 1408 // FlowGraphCompiler::SlowPathEnvironmentFor.
1409 void FlowGraphCompiler::SaveLiveRegisters(LocationSummary* locs) { 1409 void FlowGraphCompiler::SaveLiveRegisters(LocationSummary* locs) {
1410 #if defined(DEBUG)
1411 locs->CheckWritableInputs();
1412 #endif
1413
1410 // TODO(vegorov): consider saving only caller save (volatile) registers. 1414 // TODO(vegorov): consider saving only caller save (volatile) registers.
1411 const intptr_t xmm_regs_count = locs->live_registers()->FpuRegisterCount(); 1415 const intptr_t xmm_regs_count = locs->live_registers()->FpuRegisterCount();
1412 if (xmm_regs_count > 0) { 1416 if (xmm_regs_count > 0) {
1413 __ subl(ESP, Immediate(xmm_regs_count * kFpuRegisterSize)); 1417 __ subl(ESP, Immediate(xmm_regs_count * kFpuRegisterSize));
1414 // Store XMM registers with the lowest register number at the lowest 1418 // Store XMM registers with the lowest register number at the lowest
1415 // address. 1419 // address.
1416 intptr_t offset = 0; 1420 intptr_t offset = 0;
1417 for (intptr_t reg_idx = 0; reg_idx < kNumberOfXmmRegisters; ++reg_idx) { 1421 for (intptr_t reg_idx = 0; reg_idx < kNumberOfXmmRegisters; ++reg_idx) {
1418 XmmRegister xmm_reg = static_cast<XmmRegister>(reg_idx); 1422 XmmRegister xmm_reg = static_cast<XmmRegister>(reg_idx);
1419 if (locs->live_registers()->ContainsFpuRegister(xmm_reg)) { 1423 if (locs->live_registers()->ContainsFpuRegister(xmm_reg)) {
(...skipping 348 matching lines...) Expand 10 before | Expand all | Expand 10 after
1768 __ movups(reg, Address(ESP, 0)); 1772 __ movups(reg, Address(ESP, 0));
1769 __ addl(ESP, Immediate(kFpuRegisterSize)); 1773 __ addl(ESP, Immediate(kFpuRegisterSize));
1770 } 1774 }
1771 1775
1772 1776
1773 #undef __ 1777 #undef __
1774 1778
1775 } // namespace dart 1779 } // namespace dart
1776 1780
1777 #endif // defined TARGET_ARCH_IA32 1781 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698