Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2445)

Side by Side Diff: runtime/vm/flow_graph_allocator.cc

Issue 517343002: Ensure that BoxInt32 input is correctly preserved on the slow-path. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/flow_graph_allocator.h" 5 #include "vm/flow_graph_allocator.h"
6 6
7 #include "vm/bit_vector.h" 7 #include "vm/bit_vector.h"
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 #include "vm/il_printer.h" 9 #include "vm/il_printer.h"
10 #include "vm/flow_graph.h" 10 #include "vm/flow_graph.h"
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 BitVector* kill = kill_[i]; 151 BitVector* kill = kill_[i];
152 BitVector* live_in = live_in_[i]; 152 BitVector* live_in = live_in_[i];
153 153
154 // Iterate backwards starting at the last instruction. 154 // Iterate backwards starting at the last instruction.
155 for (BackwardInstructionIterator it(block); !it.Done(); it.Advance()) { 155 for (BackwardInstructionIterator it(block); !it.Done(); it.Advance()) {
156 Instruction* current = it.Current(); 156 Instruction* current = it.Current();
157 157
158 // Initialize location summary for instruction. 158 // Initialize location summary for instruction.
159 current->InitializeLocationSummary(Isolate::Current(), true); // opt 159 current->InitializeLocationSummary(Isolate::Current(), true); // opt
160 LocationSummary* locs = current->locs(); 160 LocationSummary* locs = current->locs();
161 #if DEBUG
162 locs->DiscoverWritableInputs();
163 #endif
161 164
162 // Handle definitions. 165 // Handle definitions.
163 Definition* current_def = current->AsDefinition(); 166 Definition* current_def = current->AsDefinition();
164 if ((current_def != NULL) && current_def->HasSSATemp()) { 167 if ((current_def != NULL) && current_def->HasSSATemp()) {
165 kill->Add(current_def->ssa_temp_index()); 168 kill->Add(current_def->ssa_temp_index());
166 live_in->Remove(current_def->ssa_temp_index()); 169 live_in->Remove(current_def->ssa_temp_index());
167 if (current_def->HasPairRepresentation()) { 170 if (current_def->HasPairRepresentation()) {
168 kill->Add(ToSecondPairVreg(current_def->ssa_temp_index())); 171 kill->Add(ToSecondPairVreg(current_def->ssa_temp_index()));
169 live_in->Remove(ToSecondPairVreg(current_def->ssa_temp_index())); 172 live_in->Remove(ToSecondPairVreg(current_def->ssa_temp_index()));
170 } 173 }
(...skipping 2746 matching lines...) Expand 10 before | Expand all | Expand 10 after
2917 OS::Print("-- [after ssa allocator] ir [%s] -------------\n", 2920 OS::Print("-- [after ssa allocator] ir [%s] -------------\n",
2918 function.ToFullyQualifiedCString()); 2921 function.ToFullyQualifiedCString());
2919 FlowGraphPrinter printer(flow_graph_, true); 2922 FlowGraphPrinter printer(flow_graph_, true);
2920 printer.PrintBlocks(); 2923 printer.PrintBlocks();
2921 OS::Print("----------------------------------------------\n"); 2924 OS::Print("----------------------------------------------\n");
2922 } 2925 }
2923 } 2926 }
2924 2927
2925 2928
2926 } // namespace dart 2929 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698