Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Side by Side Diff: runtime/vm/flow_graph_compiler_arm64.cc

Issue 517343002: Ensure that BoxInt32 input is correctly preserved on the slow-path. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64.
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 1386 matching lines...) Expand 10 before | Expand all | Expand 10 after
1397 __ Pop(left); 1397 __ Pop(left);
1398 } else { 1398 } else {
1399 __ CompareRegisters(left, right); 1399 __ CompareRegisters(left, right);
1400 } 1400 }
1401 } 1401 }
1402 1402
1403 1403
1404 // This function must be in sync with FlowGraphCompiler::RecordSafepoint and 1404 // This function must be in sync with FlowGraphCompiler::RecordSafepoint and
1405 // FlowGraphCompiler::SlowPathEnvironmentFor. 1405 // FlowGraphCompiler::SlowPathEnvironmentFor.
1406 void FlowGraphCompiler::SaveLiveRegisters(LocationSummary* locs) { 1406 void FlowGraphCompiler::SaveLiveRegisters(LocationSummary* locs) {
1407 #if defined(DEBUG)
1408 locs->CheckWritableInputs();
1409 #endif
1410
1407 // TODO(vegorov): consider saving only caller save (volatile) registers. 1411 // TODO(vegorov): consider saving only caller save (volatile) registers.
1408 const intptr_t fpu_regs_count = locs->live_registers()->FpuRegisterCount(); 1412 const intptr_t fpu_regs_count = locs->live_registers()->FpuRegisterCount();
1409 if (fpu_regs_count > 0) { 1413 if (fpu_regs_count > 0) {
1410 // Store fpu registers with the lowest register number at the lowest 1414 // Store fpu registers with the lowest register number at the lowest
1411 // address. 1415 // address.
1412 for (intptr_t reg_idx = kNumberOfVRegisters - 1; 1416 for (intptr_t reg_idx = kNumberOfVRegisters - 1;
1413 reg_idx >= 0; --reg_idx) { 1417 reg_idx >= 0; --reg_idx) {
1414 VRegister fpu_reg = static_cast<VRegister>(reg_idx); 1418 VRegister fpu_reg = static_cast<VRegister>(reg_idx);
1415 if (locs->live_registers()->ContainsFpuRegister(fpu_reg)) { 1419 if (locs->live_registers()->ContainsFpuRegister(fpu_reg)) {
1416 __ PushQuad(fpu_reg); 1420 __ PushQuad(fpu_reg);
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
1732 void ParallelMoveResolver::RestoreFpuScratch(FpuRegister reg) { 1736 void ParallelMoveResolver::RestoreFpuScratch(FpuRegister reg) {
1733 UNIMPLEMENTED(); 1737 UNIMPLEMENTED();
1734 } 1738 }
1735 1739
1736 1740
1737 #undef __ 1741 #undef __
1738 1742
1739 } // namespace dart 1743 } // namespace dart
1740 1744
1741 #endif // defined TARGET_ARCH_ARM64 1745 #endif // defined TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698