Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Side by Side Diff: runtime/vm/intermediate_language_arm.cc

Issue 517343002: Ensure that BoxInt32 input is correctly preserved on the slow-path. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 1996 matching lines...) Expand 10 before | Expand all | Expand 10 after
2007 2007
2008 return; 2008 return;
2009 } 2009 }
2010 2010
2011 if (IsPotentialUnboxedStore()) { 2011 if (IsPotentialUnboxedStore()) {
2012 const Register value_reg = locs()->in(1).reg(); 2012 const Register value_reg = locs()->in(1).reg();
2013 const Register temp = locs()->temp(0).reg(); 2013 const Register temp = locs()->temp(0).reg();
2014 const Register temp2 = locs()->temp(1).reg(); 2014 const Register temp2 = locs()->temp(1).reg();
2015 const DRegister fpu_temp = EvenDRegisterOf(locs()->temp(2).fpu_reg()); 2015 const DRegister fpu_temp = EvenDRegisterOf(locs()->temp(2).fpu_reg());
2016 2016
2017 if (ShouldEmitStoreBarrier()) {
2018 // Value input is a writable register and should be manually preserved
2019 // across allocation slow-path.
2020 locs()->live_registers()->Add(locs()->in(1), kTagged);
2021 }
2022
2017 Label store_pointer; 2023 Label store_pointer;
2018 Label store_double; 2024 Label store_double;
2019 Label store_float32x4; 2025 Label store_float32x4;
2020 Label store_float64x2; 2026 Label store_float64x2;
2021 2027
2022 __ LoadObject(temp, Field::ZoneHandle(field().raw())); 2028 __ LoadObject(temp, Field::ZoneHandle(field().raw()));
2023 2029
2024 __ ldr(temp2, FieldAddress(temp, Field::is_nullable_offset())); 2030 __ ldr(temp2, FieldAddress(temp, Field::is_nullable_offset()));
2025 __ CompareImmediate(temp2, kNullCid); 2031 __ CompareImmediate(temp2, kNullCid);
2026 __ b(&store_pointer, EQ); 2032 __ b(&store_pointer, EQ);
(...skipping 5188 matching lines...) Expand 10 before | Expand all | Expand 10 after
7215 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs()); 7221 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs());
7216 #if defined(DEBUG) 7222 #if defined(DEBUG)
7217 __ LoadImmediate(R4, kInvalidObjectPointer); 7223 __ LoadImmediate(R4, kInvalidObjectPointer);
7218 __ LoadImmediate(R5, kInvalidObjectPointer); 7224 __ LoadImmediate(R5, kInvalidObjectPointer);
7219 #endif 7225 #endif
7220 } 7226 }
7221 7227
7222 } // namespace dart 7228 } // namespace dart
7223 7229
7224 #endif // defined TARGET_ARCH_ARM 7230 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698