Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Side by Side Diff: runtime/vm/intermediate_language_x64.cc

Issue 517343002: Ensure that BoxInt32 input is correctly preserved on the slow-path. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | runtime/vm/locations.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 1663 matching lines...) Expand 10 before | Expand all | Expand 10 after
1674 } 1674 }
1675 return; 1675 return;
1676 } 1676 }
1677 1677
1678 if (IsPotentialUnboxedStore()) { 1678 if (IsPotentialUnboxedStore()) {
1679 Register value_reg = locs()->in(1).reg(); 1679 Register value_reg = locs()->in(1).reg();
1680 Register temp = locs()->temp(0).reg(); 1680 Register temp = locs()->temp(0).reg();
1681 Register temp2 = locs()->temp(1).reg(); 1681 Register temp2 = locs()->temp(1).reg();
1682 FpuRegister fpu_temp = locs()->temp(2).fpu_reg(); 1682 FpuRegister fpu_temp = locs()->temp(2).fpu_reg();
1683 1683
1684 if (ShouldEmitStoreBarrier()) {
1685 // Value input is a writable register and should be manually preserved
1686 // across allocation slow-path.
1687 locs()->live_registers()->Add(locs()->in(1), kTagged);
1688 }
1689
1684 Label store_pointer; 1690 Label store_pointer;
1685 Label store_double; 1691 Label store_double;
1686 Label store_float32x4; 1692 Label store_float32x4;
1687 Label store_float64x2; 1693 Label store_float64x2;
1688 1694
1689 __ LoadObject(temp, Field::ZoneHandle(field().raw()), PP); 1695 __ LoadObject(temp, Field::ZoneHandle(field().raw()), PP);
1690 1696
1691 __ cmpl(FieldAddress(temp, Field::is_nullable_offset()), 1697 __ cmpl(FieldAddress(temp, Field::is_nullable_offset()),
1692 Immediate(kNullCid)); 1698 Immediate(kNullCid));
1693 __ j(EQUAL, &store_pointer); 1699 __ j(EQUAL, &store_pointer);
(...skipping 4144 matching lines...) Expand 10 before | Expand all | Expand 10 after
5838 __ movq(R10, Immediate(kInvalidObjectPointer)); 5844 __ movq(R10, Immediate(kInvalidObjectPointer));
5839 __ movq(RBX, Immediate(kInvalidObjectPointer)); 5845 __ movq(RBX, Immediate(kInvalidObjectPointer));
5840 #endif 5846 #endif
5841 } 5847 }
5842 5848
5843 } // namespace dart 5849 } // namespace dart
5844 5850
5845 #undef __ 5851 #undef __
5846 5852
5847 #endif // defined TARGET_ARCH_X64 5853 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | runtime/vm/locations.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698