Make RefactoringStatus a collection of generated RefactoringProblems.

Make RefactoringStatus a collection of generated RefactoringProblems.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=39494

[Paul Berry, 2014-08-22 12:36:03]

lgtm

https://codereview.chromium.org/485083004/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/correction/status.dart (right):

https://codereview.chromium.org/485083004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/status.dart:192: * guarantee as
to which will be returned.
If you don't want to make a guarantee as to which problem will be returned, then
it seems odd that the summary of the function (on line 189) says "Returns the
*first* [RefactoringProblem] with the highest severity."

[Brian Wilkerson, 2014-08-22 14:24:04]

LGTM

https://codereview.chromium.org/485083004/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/correction/status.dart (right):

https://codereview.chromium.org/485083004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/status.dart:19: Location
createLocation(AnalysisContext context, Source source,
I'd like this better if these were factory methods on Location.

https://codereview.chromium.org/485083004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/status.dart:87:
RefactoringProblemSeverity _maxSeverity(RefactoringProblemSeverity a,
And this should be an instance method on RefactoringProblemSeverity.

https://codereview.chromium.org/485083004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/status.dart:90: return b;
For consistency we should return 'a' if 'b' is null.

[scheglov, 2014-08-22 14:45:45]

Committed patchset #1 manually as 39494 (presubmit successful).

[scheglov, 2014-08-22 14:46:13]

https://codereview.chromium.org/485083004/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/correction/status.dart (right):

https://codereview.chromium.org/485083004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/status.dart:19: Location
createLocation(AnalysisContext context, Source source,
On 2014/08/22 14:24:04, Brian Wilkerson wrote:
> I'd like this better if these were factory methods on Location.

Agree.
It's the next step.
I decided to do my first code generation in the next CL.

https://codereview.chromium.org/485083004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/status.dart:87:
RefactoringProblemSeverity _maxSeverity(RefactoringProblemSeverity a,
On 2014/08/22 14:24:04, Brian Wilkerson wrote:
> And this should be an instance method on RefactoringProblemSeverity.

Do you mean a *static* method?
The initial values of a severity is null, because we don't have yet a problem
and there is no OK severity.

https://codereview.chromium.org/485083004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/status.dart:90: return b;
On 2014/08/22 14:24:04, Brian Wilkerson wrote:
> For consistency we should return 'a' if 'b' is null.

Done.

https://codereview.chromium.org/485083004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/status.dart:192: * guarantee as
to which will be returned.
On 2014/08/22 12:36:03, Paul Berry wrote:
> If you don't want to make a guarantee as to which problem will be returned,
then
> it seems odd that the summary of the function (on line 189) says "Returns the
> *first* [RefactoringProblem] with the highest severity."

Acknowledged.