Make RefactoringStatus a collection of generated RefactoringProblems.

pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.src.refactoring.rename_class_member;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol2.dart' show SourceEdit;
 import 'package:analysis_server/src/services/correction/change.dart';
@@ skipping 23 matching lines @@
       return "Rename Type Parameter";
     }
     if (element is FieldElement) {
       return "Rename Field";
     }
     return "Rename Method";
   }
 
   @override
   Future<RefactoringStatus> checkFinalConditions() {
-    _validator = new _RenameClassMemberValidator(
-        searchEngine,
-        element,
-        newName);
+    _validator =
+        new _RenameClassMemberValidator(searchEngine, element, newName);
     return _validator.validate();
   }
 
   @override
   Future<RefactoringStatus> checkInitialConditions() {
     RefactoringStatus result = new RefactoringStatus();
     if (element is MethodElement && (element as MethodElement).isOperator) {
       result.addFatalError('Cannot rename operator.');
     }
     return new Future.value(result);
@@ skipping 43 matching lines @@
           continue;
         }
         // check the element being renamed is accessible
         {
           LibraryElement whereLibrary = reference.element.library;
           if (!element.isAccessibleIn(whereLibrary)) {
             continue;
           }
         }
         // add edit
-        SourceEdit edit = createReferenceEdit(reference, newName,
-            id: _newPotentialId());
+        SourceEdit edit =
+            createReferenceEdit(reference, newName, id: _newPotentialId());
         change.addEdit(reference.file, edit);
       }
     }).then((_) => change);
   }
 
   String _newPotentialId() {
     String id = potentialEditIds.length.toString();
     potentialEditIds.add(id);
     return id;
   }
@@ skipping 21 matching lines @@
     RefactoringStatus result = new RefactoringStatus();
     ClassElement elementClass = element.enclosingElement;
     // check if there is a member with "newName" in the same ClassElement
     for (Element newNameMember in getChildren(elementClass, newName)) {
       result.addError(
           format(
               "Class '{0}' already declares {1} with name '{2}'.",
               elementClass.displayName,
               getElementKindName(newNameMember),
               newName),
-          new RefactoringStatusContext.forElement(newNameMember));
+          createLocation_forElement(newNameMember));
     }
     // do chained computations
     Set<ClassElement> superClasses = getSuperClasses(elementClass);
     Set<ClassElement> subClasses;
     return _prepareReferences().then((_) {
       return getSubClasses(searchEngine, elementClass).then((_subs) {
         subClasses = _subs;
       });
     }).then((_) {
       // check shadowing in hierarchy
       return searchEngine.searchElementDeclarations(newName).then((decls) {
         for (SearchMatch decl in decls) {
           Element nameElement = getSyntheticAccessorVariable(decl.element);
           Element nameClass = nameElement.enclosingElement;
           // renamed Element shadows member of superclass
           if (superClasses.contains(nameClass)) {
             result.addError(
                 format(
                     "Renamed {0} will shadow {1} '{2}'.",
                     getElementKindName(element),
                     getElementKindName(nameElement),
                     getElementQualifiedName(nameElement)),
-                new RefactoringStatusContext.forElement(nameElement));
+                createLocation_forElement(nameElement));
           }
           // renamed Element is shadowed by member of subclass
           if (subClasses.contains(nameClass)) {
             result.addError(
                 format(
                     "Renamed {0} will be shadowed by {1} '{2}'.",
                     getElementKindName(element),
                     getElementKindName(nameElement),
                     getElementQualifiedName(nameElement)),
-                new RefactoringStatusContext.forElement(nameElement));
+                createLocation_forElement(nameElement));
           }
           // renamed Element is shadowed by local
           if (nameElement is LocalElement) {
             LocalElement localElement = nameElement;
             ClassElement enclosingClass =
                 nameElement.getAncestor((element) => element is ClassElement);
             if (enclosingClass == elementClass ||
                 subClasses.contains(enclosingClass)) {
               for (SearchMatch reference in references) {
                 if (isReferenceInLocalRange(localElement, reference)) {
                   result.addError(
                       format(
                           "Usage of renamed {0} will be shadowed by {1} '{2}'.",
                           getElementKindName(element),
                           getElementKindName(localElement),
                           localElement.displayName),
-                      new RefactoringStatusContext.forMatch(reference));
+                      createLocation_forMatch(reference));
                 }
               }
             }
           }
         }
       });
     }).then((_) => result);
   }
 
   /**
@@ skipping 18 matching lines @@
   Future _prepareReferences() {
     return _prepareElements().then((_) {
       return Future.forEach(elements, (Element element) {
         return searchEngine.searchReferences(element).then((references) {
           this.references.addAll(references);
         });
       });
     });
   }
 }