Make RefactoringStatus a collection of generated RefactoringProblems.

pkg/analysis_server/test/services/refactoring/rename_local_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.refactoring.rename_local;
 
-import 'package:analysis_server/src/services/correction/status.dart';
+import 'package:analysis_server/src/protocol2.dart';
 import 'package:analysis_testing/reflective_tests.dart';
 import 'package:unittest/unittest.dart';
 
 import 'abstract_rename.dart';
 
 
 main() {
   groupSep = ' | ';
   runReflectiveTests(RenameLocalTest);
 }
 
 
 @ReflectiveTestCase()
 class RenameLocalTest extends RenameRefactoringTest {
   test_checkFinalConditions_hasLocalFunction_after() {
     indexTestUnit('''
 main() {
   int test = 0;
   newName() => 1;
 }
 ''');
     createRenameRefactoringAtString('test = 0');
     // check status
     refactoring.newName = 'newName';
     return refactoring.checkFinalConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.ERROR,
+          RefactoringProblemSeverity.ERROR,
           expectedMessage: "Duplicate function 'newName'.",
           expectedContextSearch: 'newName() => 1');
     });
   }
 
   test_checkFinalConditions_hasLocalFunction_before() {
     indexTestUnit('''
 main() {
   newName() => 1;
   int test = 0;
 }
 ''');
     createRenameRefactoringAtString('test = 0');
     // check status
     refactoring.newName = 'newName';
     return refactoring.checkFinalConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.ERROR,
+          RefactoringProblemSeverity.ERROR,
           expectedMessage: "Duplicate function 'newName'.");
     });
   }
 
   test_checkFinalConditions_hasLocalVariable_after() {
     indexTestUnit('''
 main() {
   int test = 0;
   var newName = 1;
 }
 ''');
     createRenameRefactoringAtString('test = 0');
     // check status
     refactoring.newName = 'newName';
     return refactoring.checkFinalConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.ERROR,
+          RefactoringProblemSeverity.ERROR,
           expectedMessage: "Duplicate local variable 'newName'.",
           expectedContextSearch: 'newName = 1;');
     });
   }
 
   test_checkFinalConditions_hasLocalVariable_before() {
     indexTestUnit('''
 main() {
   var newName = 1;
   int test = 0;
 }
 ''');
     createRenameRefactoringAtString('test = 0');
     // check status
     refactoring.newName = 'newName';
     return refactoring.checkFinalConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.ERROR,
+          RefactoringProblemSeverity.ERROR,
           expectedMessage: "Duplicate local variable 'newName'.",
           expectedContextSearch: 'newName = 1;');
     });
   }
 
   test_checkFinalConditions_hasLocalVariable_otherBlock() {
     indexTestUnit('''
 main() {
   {
     var newName = 1;
@@ skipping 33 matching lines @@
     print(newName);
   }
 }
 ''');
     createRenameRefactoringAtString('test = 0');
     // check status
     refactoring.newName = 'newName';
     return refactoring.checkFinalConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.ERROR,
+          RefactoringProblemSeverity.ERROR,
           expectedMessage: 'Usage of field "A.newName" declared in "test.dart" '
               'will be shadowed by renamed local variable.',
           expectedContextSearch: 'newName);');
     });
   }
 
   test_checkFinalConditions_shadows_classMemberOK_qualifiedReference() {
     indexTestUnit('''
 class A {
   var newName = 1;
@@ skipping 16 matching lines @@
   var test = 0;
   newName(); // ref
 }
 ''');
     createRenameRefactoringAtString('test = 0');
     // check status
     refactoring.newName = 'newName';
     return refactoring.checkFinalConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.ERROR,
+          RefactoringProblemSeverity.ERROR,
           expectedContextSearch: 'newName(); // ref');
     });
   }
 
   test_checkNewName_FunctionElement() {
     indexTestUnit('''
 main() {
   int test() {}
 }
 ''');
     createRenameRefactoringAtString('test() {}');
     // null
     refactoring.newName = null;
     assertRefactoringStatus(
         refactoring.checkNewName(),
-        RefactoringStatusSeverity.ERROR,
+        RefactoringProblemSeverity.ERROR,
         expectedMessage: "Function name must not be null.");
     // OK
     refactoring.newName = 'newName';
     assertRefactoringStatusOK(refactoring.checkNewName());
   }
 
   test_checkNewName_LocalVariableElement() {
     indexTestUnit('''
 main() {
   int test = 0;
 }
 ''');
     createRenameRefactoringAtString('test = 0;');
     // null
     refactoring.newName = null;
     assertRefactoringStatus(
         refactoring.checkNewName(),
-        RefactoringStatusSeverity.ERROR,
+        RefactoringProblemSeverity.ERROR,
         expectedMessage: "Variable name must not be null.");
     // empty
     refactoring.newName = '';
     assertRefactoringStatus(
         refactoring.checkNewName(),
-        RefactoringStatusSeverity.ERROR,
+        RefactoringProblemSeverity.ERROR,
         expectedMessage: "Variable name must not be empty.");
     // OK
     refactoring.newName = 'newName';
     assertRefactoringStatusOK(refactoring.checkNewName());
   }
 
   test_checkNewName_LocalVariableElement_const() {
     indexTestUnit('''
 main() {
   const int TEST = 0;
 }
 ''');
     createRenameRefactoringAtString('TEST = 0;');
     // null
     refactoring.newName = null;
     assertRefactoringStatus(
         refactoring.checkNewName(),
-        RefactoringStatusSeverity.ERROR,
+        RefactoringProblemSeverity.ERROR,
         expectedMessage: "Constant name must not be null.");
     // empty
     refactoring.newName = '';
     assertRefactoringStatus(
         refactoring.checkNewName(),
-        RefactoringStatusSeverity.ERROR,
+        RefactoringProblemSeverity.ERROR,
         expectedMessage: "Constant name must not be empty.");
     // same
     refactoring.newName = 'TEST';
     assertRefactoringStatus(
         refactoring.checkNewName(),
-        RefactoringStatusSeverity.FATAL,
+        RefactoringProblemSeverity.FATAL,
         expectedMessage: "The new name must be different than the current name.");
     // OK
     refactoring.newName = 'NEW_NAME';
     assertRefactoringStatusOK(refactoring.checkNewName());
   }
 
   test_checkNewName_ParameterElement() {
     indexTestUnit('''
 main(test) {
 }
 ''');
     createRenameRefactoringAtString('test) {');
     // null
     refactoring.newName = null;
     assertRefactoringStatus(
         refactoring.checkNewName(),
-        RefactoringStatusSeverity.ERROR,
+        RefactoringProblemSeverity.ERROR,
         expectedMessage: "Parameter name must not be null.");
     // OK
     refactoring.newName = 'newName';
     assertRefactoringStatusOK(refactoring.checkNewName());
   }
 
   test_createChange_localFunction() {
     indexTestUnit('''
 main() {
   int test() => 0;
@@ skipping 183 matching lines @@
 main() {
   int test = 0;
 }
 ''');
     // configure refactoring
     createRenameRefactoringAtString('test = 0');
     // old name
     expect(refactoring.oldName, 'test');
   }
 }