Make RefactoringStatus a collection of generated RefactoringProblems.

pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.refactoring.rename_class_member;
 
-import 'package:analysis_server/src/services/correction/status.dart';
+import 'package:analysis_server/src/protocol2.dart';
 import 'package:analysis_testing/reflective_tests.dart';
 import 'package:unittest/unittest.dart';
 
 import 'abstract_rename.dart';
 
 
 main() {
   groupSep = ' | ';
   runReflectiveTests(RenameClassMemberTest);
 }
@@ skipping 29 matching lines @@
   test() {}
   newName() {} // existing
 }
 ''');
     createRenameRefactoringAtString('test() {}');
     // check status
     refactoring.newName = 'newName';
     return refactoring.checkFinalConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.ERROR,
+          RefactoringProblemSeverity.ERROR,
           expectedMessage: "Class 'A' already declares method with name 'newName'.",
           expectedContextSearch: 'newName() {} // existing');
     });
   }
 
   test_checkFinalConditions_shadowed_byLocal_OK_qualifiedReference() {
     indexTestUnit('''
 class A {
   test() {}
   main() {
@@ skipping 36 matching lines @@
     test(); // marker
   }
 }
 ''');
     createRenameRefactoringAtString('test() {}');
     // check status
     refactoring.newName = 'newName';
     return refactoring.checkFinalConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.ERROR,
+          RefactoringProblemSeverity.ERROR,
           expectedMessage:
               "Usage of renamed method will be shadowed by local variable 'newName'.",
           expectedContextSearch: 'test(); // marker');
     });
   }
 
   test_checkFinalConditions_shadowed_byLocal_inSubClass() {
     indexTestUnit('''
 class A {
   test() {}
 }
 class B extends A {
   main() {
     var newName;
     test(); // marker
   }
 }
 ''');
     createRenameRefactoringAtString('test() {}');
     // check status
     refactoring.newName = 'newName';
     return refactoring.checkFinalConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.ERROR,
+          RefactoringProblemSeverity.ERROR,
           expectedMessage:
               "Usage of renamed method will be shadowed by local variable 'newName'.",
           expectedContextSearch: 'test(); // marker');
     });
   }
 
   test_checkFinalConditions_shadowed_byParameter_inSameClass() {
     indexTestUnit('''
 class A {
   test() {}
   main(newName) {
     test(); // marker
   }
 }
 ''');
     createRenameRefactoringAtString('test() {}');
     // check status
     refactoring.newName = 'newName';
     return refactoring.checkFinalConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.ERROR,
+          RefactoringProblemSeverity.ERROR,
           expectedMessage:
               "Usage of renamed method will be shadowed by parameter 'newName'.",
           expectedContextSearch: 'test(); // marker');
     });
   }
 
   test_checkFinalConditions_shadowed_inSubClass() {
     indexTestUnit('''
 class A {
   newName() {} // marker
 }
 class B extends A {
   test() {}
   main() {
     newName();
   }
 }
 ''');
     createRenameRefactoringAtString('test() {}');
     // check status
     refactoring.newName = 'newName';
     return refactoring.checkFinalConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.ERROR,
+          RefactoringProblemSeverity.ERROR,
           expectedMessage: "Renamed method will shadow method 'A.newName'.",
           expectedContextSearch: 'newName() {} // marker');
     });
   }
 
   test_checkFinalConditions_shadowsSuper_MethodElement() {
     indexTestUnit('''
 class A {
   test() {}
 }
 class B extends A {
   newName() {} // marker
   main() {
     test();
   }
 }
 ''');
     createRenameRefactoringAtString('test() {}');
     // check status
     refactoring.newName = 'newName';
     return refactoring.checkFinalConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.ERROR,
+          RefactoringProblemSeverity.ERROR,
           expectedMessage: "Renamed method will be shadowed by method 'B.newName'.",
           expectedContextSearch: 'newName() {} // marker');
     });
   }
 
   test_checkFinalConditions_shadowsSuper_inSubClass_FieldElement() {
     indexTestUnit('''
 class A {
   int newName; // marker
 }
 class B extends A {
   test() {}
 }
 class C extends B {
   main() {
     print(newName);
   }
 }
 ''');
     createRenameRefactoringAtString('test() {}');
     // check status
     refactoring.newName = 'newName';
     return refactoring.checkFinalConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.ERROR,
+          RefactoringProblemSeverity.ERROR,
           expectedMessage: "Renamed method will shadow field 'A.newName'.",
           expectedContextSearch: 'newName; // marker');
     });
   }
 
   test_checkInitialConditions_operator() {
     indexTestUnit('''
 class A {
   operator -(other) => this;
 }
 ''');
     createRenameRefactoringAtString('-(other)');
     // check status
     refactoring.newName = 'newName';
     return refactoring.checkInitialConditions().then((status) {
-      assertRefactoringStatus(status, RefactoringStatusSeverity.FATAL);
+      assertRefactoringStatus(status, RefactoringProblemSeverity.FATAL);
     });
   }
 
   test_checkNewName_FieldElement() {
     indexTestUnit('''
 class A {
   int test;
 }
 ''');
     createRenameRefactoringAtString('test;');
     // null
     refactoring.newName = null;
     assertRefactoringStatus(
         refactoring.checkNewName(),
-        RefactoringStatusSeverity.ERROR,
+        RefactoringProblemSeverity.ERROR,
         expectedMessage: "Field name must not be null.");
     // OK
     refactoring.newName = 'newName';
     assertRefactoringStatusOK(refactoring.checkNewName());
   }
 
   test_checkNewName_FieldElement_const() {
     indexTestUnit('''
 class A {
   static const int TEST = 0;
 }
 ''');
     createRenameRefactoringAtString('TEST =');
     // null
     refactoring.newName = null;
     assertRefactoringStatus(
         refactoring.checkNewName(),
-        RefactoringStatusSeverity.ERROR,
+        RefactoringProblemSeverity.ERROR,
         expectedMessage: "Constant name must not be null.");
     // not upper case
     refactoring.newName = 'newName';
     assertRefactoringStatus(
         refactoring.checkNewName(),
-        RefactoringStatusSeverity.WARNING);
+        RefactoringProblemSeverity.WARNING);
     // OK
     refactoring.newName = 'NEW_NAME';
     assertRefactoringStatusOK(refactoring.checkNewName());
   }
 
   test_checkNewName_MethodElement() {
     indexTestUnit('''
 class A {
   test() {}
 }
 ''');
     createRenameRefactoringAtString('test() {}');
     // null
     refactoring.newName = null;
     assertRefactoringStatus(
         refactoring.checkNewName(),
-        RefactoringStatusSeverity.ERROR,
+        RefactoringProblemSeverity.ERROR,
         expectedMessage: "Method name must not be null.");
     // empty
     refactoring.newName = '';
     assertRefactoringStatus(
         refactoring.checkNewName(),
-        RefactoringStatusSeverity.ERROR,
+        RefactoringProblemSeverity.ERROR,
         expectedMessage: "Method name must not be empty.");
     // same
     refactoring.newName = 'test';
     assertRefactoringStatus(
         refactoring.checkNewName(),
-        RefactoringStatusSeverity.FATAL,
+        RefactoringProblemSeverity.FATAL,
         expectedMessage: "The new name must be different than the current name.");
     // OK
     refactoring.newName = 'newName';
     assertRefactoringStatusOK(refactoring.checkNewName());
   }
 
   test_createChange_FieldElement() {
     indexTestUnit('''
 class A {
   int test; // marker
@@ skipping 394 matching lines @@
     // validate change
     return assertSuccessfulRename('''
 class A<NewName> {
   NewName field;
   List<NewName> items;
   NewName method(NewName p) => null;
 }
 ''');
   }
 }