Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/extract_local.dart

Issue 485083004: Make RefactoringStatus a collection of generated RefactoringProblems. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/refactoring/extract_local.dart
diff --git a/pkg/analysis_server/lib/src/services/refactoring/extract_local.dart b/pkg/analysis_server/lib/src/services/refactoring/extract_local.dart
index c7c72f82f39888015417d72a0832390d67a0fcc0..37a8791e708be91af278703cf4e630f4af4f2d6f 100644
--- a/pkg/analysis_server/lib/src/services/refactoring/extract_local.dart
+++ b/pkg/analysis_server/lib/src/services/refactoring/extract_local.dart
@@ -6,7 +6,7 @@ library services.src.refactoring.extract_local;
import 'dart:async';
-import 'package:analysis_server/src/protocol2.dart' show SourceEdit;
+import 'package:analysis_server/src/protocol2.dart' show Location, SourceEdit;
import 'package:analysis_server/src/services/correction/change.dart';
import 'package:analysis_server/src/services/correction/name_suggestion.dart';
import 'package:analysis_server/src/services/correction/selection_analyzer.dart';
@@ -383,7 +383,7 @@ class _ExtractExpressionAnalyzer extends SelectionAnalyzer {
if (_isFirstSelectedNode(lhs)) {
_invalidSelection(
'Cannot extract the left-hand side of an assignment.',
- new RefactoringStatusContext.forNode(lhs));
+ createLocation_forNode(lhs));
}
return null;
}
@@ -414,10 +414,10 @@ class _ExtractExpressionAnalyzer extends SelectionAnalyzer {
}
/**
- * Records fatal error with given message and [RefactoringStatusContext].
+ * Records fatal error with given message and [Locatiom].
*/
- void _invalidSelection(String message, RefactoringStatusContext context) {
- status.addFatalError(message, context);
+ void _invalidSelection(String message, Location location) {
+ status.addFatalError(message, location);
reset();
}

Powered by Google App Engine
This is Rietveld 408576698