pkg/analysis_server/test/services/refactoring/rename_library_test.dart - Issue 485083004: Make RefactoringStatus a collection of generated RefactoringProblems.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/refactoring/rename_library_test.dart

Issue 485083004: Make RefactoringStatus a collection of generated RefactoringProblems. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/lib/src/services/correction/status.dart ('K') | « pkg/analysis_server/test/services/refactoring/rename_import_test.dart ('k') | pkg/analysis_server/test/services/refactoring/rename_local_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/refactoring/rename_library_test.dart

diff --git a/pkg/analysis_server/test/services/refactoring/rename_library_test.dart b/pkg/analysis_server/test/services/refactoring/rename_library_test.dart

index 06bbf61de41c1d24e3058cf5b6cf32b5d6221c5f..df152a63d61941348e13ca729cb3030358ba0eca 100644

--- a/pkg/analysis_server/test/services/refactoring/rename_library_test.dart

+++ b/pkg/analysis_server/test/services/refactoring/rename_library_test.dart

@@ -4,7 +4,7 @@

library test.services.refactoring.rename_library;

-import 'package:analysis_server/src/services/correction/status.dart';

+import 'package:analysis_server/src/protocol2.dart';

import 'package:analysis_testing/reflective_tests.dart';

import 'package:analyzer/src/generated/source.dart';

import 'package:unittest/unittest.dart';

@@ -30,19 +30,19 @@ library my.app;

refactoring.newName = null;

assertRefactoringStatus(

refactoring.checkNewName(),

- RefactoringStatusSeverity.ERROR,

+ RefactoringProblemSeverity.ERROR,

expectedMessage: "Library name must not be null.");

// empty

refactoring.newName = '';

assertRefactoringStatus(

refactoring.checkNewName(),

- RefactoringStatusSeverity.ERROR,

+ RefactoringProblemSeverity.ERROR,

expectedMessage: "Library name must not be blank.");

// same name

refactoring.newName = 'my.app';

assertRefactoringStatus(

refactoring.checkNewName(),

- RefactoringStatusSeverity.FATAL,

+ RefactoringProblemSeverity.FATAL,

expectedMessage: "The new name must be different than the current name.");

}