Make RefactoringStatus a collection of generated RefactoringProblems.

pkg/analysis_server/test/services/refactoring/extract_local_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.refactoring.extract_local;
 
 import 'dart:async';
 
+import 'package:analysis_server/src/protocol2.dart';
 import 'package:analysis_server/src/services/correction/change.dart';
-import 'package:analysis_server/src/services/correction/status.dart';
 import 'package:analysis_server/src/services/refactoring/extract_local.dart';
 import 'package:analysis_testing/reflective_tests.dart';
 import 'package:unittest/unittest.dart';
 
 import 'abstract_refactoring.dart';
 
 
 main() {
   groupSep = ' | ';
   runReflectiveTests(ExtractLocalTest);
 }
 
 
 @ReflectiveTestCase()
 class ExtractLocalTest extends RefactoringTest {
   ExtractLocalRefactoringImpl refactoring;
 
   test_checkFinalConditions_sameVariable_after() {
     indexTestUnit('''
 main() {
   int a = 1 + 2;
   var res;
 }
 ''');
     _createRefactoringForString('1 + 2');
     // conflicting name
     return refactoring.checkAllConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.WARNING,
+          RefactoringProblemSeverity.WARNING,
           expectedMessage:
               "A variable with name 'res' is already defined in the visible scope.");
     });
   }
 
   test_checkFinalConditions_sameVariable_before() {
     indexTestUnit('''
 main() {
   var res;
   int a = 1 + 2;
 }
 ''');
     _createRefactoringForString('1 + 2');
     // conflicting name
     return refactoring.checkAllConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.WARNING,
+          RefactoringProblemSeverity.WARNING,
           expectedMessage:
               "A variable with name 'res' is already defined in the visible scope.");
     });
   }
 
   test_checkInitialConditions_assignmentLeftHandSize() {
     indexTestUnit('''
 main() {
   var v = 0;
   v = 1;
 }
 ''');
     _createRefactoringWithSuffix('v', ' = 1;');
     // check conditions
     return refactoring.checkInitialConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.FATAL,
+          RefactoringProblemSeverity.FATAL,
           expectedMessage: 'Cannot extract the left-hand side of an assignment.');
     });
   }
 
   test_checkInitialConditions_methodName_reference() {
     indexTestUnit('''
 main() {
   main();
 }
 ''');
     _createRefactoringWithSuffix('main', '();');
     // check conditions
     return refactoring.checkInitialConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.FATAL,
+          RefactoringProblemSeverity.FATAL,
           expectedMessage: 'Cannot extract a single method name.');
     });
   }
 
   test_checkInitialConditions_nameOfProperty_prefixedIdentifier() {
     indexTestUnit('''
 main(p) {
   p.value; // marker
 }
 ''');
     _createRefactoringWithSuffix('value', '; // marker');
     // check conditions
     return refactoring.checkInitialConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.FATAL,
+          RefactoringProblemSeverity.FATAL,
           expectedMessage: 'Cannot extract name part of a property access.');
     });
   }
 
   test_checkInitialConditions_nameOfProperty_propertyAccess() {
     indexTestUnit('''
 main() {
   foo().length; // marker
 }
 String foo() => '';
 ''');
     _createRefactoringWithSuffix('length', '; // marker');
     // check conditions
     return refactoring.checkInitialConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.FATAL,
+          RefactoringProblemSeverity.FATAL,
           expectedMessage: 'Cannot extract name part of a property access.');
     });
   }
 
   test_checkInitialConditions_namePartOfDeclaration_variable() {
     indexTestUnit('''
 main() {
   int vvv = 0;
 }
 ''');
     _createRefactoringWithSuffix('vvv', ' = 0;');
     // check conditions
     return refactoring.checkInitialConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.FATAL,
+          RefactoringProblemSeverity.FATAL,
           expectedMessage: 'Cannot extract the name part of a declaration.');
     });
   }
 
   test_checkInitialConditions_notPartOfFunction() {
     indexTestUnit('''
 int a = 1 + 2;
 ''');
     _createRefactoringForString('1 + 2');
     // check conditions
     return refactoring.checkInitialConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.FATAL,
+          RefactoringProblemSeverity.FATAL,
           expectedMessage:
               'Expression inside of function must be selected to activate this refactoring.');
     });
   }
 
   test_checkInitialConditions_stringSelection_leadingQuote() {
     indexTestUnit('''
 main() {
   var vvv = 'abc';
 }
 ''');
     _createRefactoringForString("'a");
     // check conditions
     return refactoring.checkInitialConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.FATAL,
+          RefactoringProblemSeverity.FATAL,
           expectedMessage:
               'Cannot extract only leading or trailing quote of string literal.');
     });
   }
 
   test_checkInitialConditions_stringSelection_trailingQuote() {
     indexTestUnit('''
 main() {
   var vvv = 'abc';
 }
 ''');
     _createRefactoringForString("c'");
     // check conditions
     return refactoring.checkInitialConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.FATAL,
+          RefactoringProblemSeverity.FATAL,
           expectedMessage:
               'Cannot extract only leading or trailing quote of string literal.');
     });
   }
 
   test_checkLocalName() {
     indexTestUnit('''
 main() {
   int a = 1 + 2;
 }
 ''');
     _createRefactoringForString('1 + 2');
     expect(refactoring.refactoringName, 'Extract Local Variable');
     // null
     refactoring.name = null;
     assertRefactoringStatus(
         refactoring.checkName(),
-        RefactoringStatusSeverity.ERROR,
+        RefactoringProblemSeverity.ERROR,
         expectedMessage: "Variable name must not be null.");
     // empty
     refactoring.name = '';
     assertRefactoringStatus(
         refactoring.checkName(),
-        RefactoringStatusSeverity.ERROR,
+        RefactoringProblemSeverity.ERROR,
         expectedMessage: "Variable name must not be empty.");
     // OK
     refactoring.name = 'res';
     assertRefactoringStatusOK(refactoring.checkName());
   }
 
   test_completeStatementExpression() {
     indexTestUnit('''
 main(p) {
   p.toString();
@@ skipping 634 matching lines @@
   var res = 'abc';
   print(res);
 }
 ''');
   }
 
   Future _assertInitialConditions_fatal_selection() {
     return refactoring.checkInitialConditions().then((status) {
       assertRefactoringStatus(
           status,
-          RefactoringStatusSeverity.FATAL,
+          RefactoringProblemSeverity.FATAL,
           expectedMessage: 'Expression must be selected to activate this refactoring.');
     });
   }
 
   /**
    * Checks that all conditions are OK and the result of applying the [Change]
    * to [testUnit] is [expectedCode].
    */
   Future _assertSuccessfulRefactoring(String expectedCode) {
     return assertRefactoringConditionsOK().then((_) {
@@ skipping 18 matching lines @@
     int length = search.length;
     _createRefactoring(offset, length);
   }
 
   void _createRefactoringWithSuffix(String selectionSearch, String suffix) {
     int offset = findOffset(selectionSearch + suffix);
     int length = selectionSearch.length;
     _createRefactoring(offset, length);
   }
 }