Last cross-platform cleanup in preparation of improved ARM code for indexed

Last cross-platform cleanup in preparation of improved ARM code for indexed
loads and stores.

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36577

[Florian Schneider, 2014-05-23 07:54:15]

dbc:

https://codereview.chromium.org/294223003/diff/1/runtime/vm/flow_graph_compil...
File runtime/vm/flow_graph_compiler_ia32.cc (right):

https://codereview.chromium.org/294223003/diff/1/runtime/vm/flow_graph_compil...
runtime/vm/flow_graph_compiler_ia32.cc:1542: Address
FlowGraphCompiler::ElementAddressForIntIndex(bool is_load,
I don't see is_load used anywhere.

[regis, 2014-05-23 14:51:05]

https://codereview.chromium.org/294223003/diff/1/runtime/vm/flow_graph_compil...
File runtime/vm/flow_graph_compiler_ia32.cc (right):

https://codereview.chromium.org/294223003/diff/1/runtime/vm/flow_graph_compil...
runtime/vm/flow_graph_compiler_ia32.cc:1542: Address
FlowGraphCompiler::ElementAddressForIntIndex(bool is_load,
On 2014/05/23 07:54:16, Florian Schneider wrote:
> I don't see is_load used anywhere.

You will see it being used on ARM in my next cl.
Unfortunately, these calls are defined in an architecture independent header and
must accommodate all architectures. There is actually little reason for that and
this could be changed at some time.

[regis, 2014-05-23 17:32:44]

I made these calls architecture dependent, which makes more sense.

PTAL

[srdjan, 2014-05-23 18:03:27]

LGTM

[regis, 2014-05-23 18:23:09]

Thanks!

I moved DataOffsetFor and ElementSizeFor from Object to Instance before
submitting, as discussed.

[regis, 2014-05-23 18:31:19]

Committed patchset #3 manually as r36577 (presubmit successful).