Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2403)

Unified Diff: runtime/vm/intrinsifier_ia32.cc

Issue 294223003: Last cross-platform cleanup in preparation of improved ARM code for indexed (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intrinsifier_arm64.cc ('k') | runtime/vm/intrinsifier_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier_ia32.cc
===================================================================
--- runtime/vm/intrinsifier_ia32.cc (revision 36576)
+++ runtime/vm/intrinsifier_ia32.cc (working copy)
@@ -1248,12 +1248,10 @@
__ movl(EAX, Address(ESP, + 1 * kWordSize)); // Receiver.
__ movl(EBX, FieldAddress(EAX, state_field.Offset())); // Field '_state'.
// Addresses of _state[0] and _state[1].
- const intptr_t index_scale =
- FlowGraphCompiler::ElementSizeFor(kTypedDataUint32ArrayCid);
- const intptr_t offset =
- FlowGraphCompiler::DataOffsetFor(kTypedDataUint32ArrayCid);
- Address addr_0 = FieldAddress(EBX, 0 * index_scale + offset);
- Address addr_1 = FieldAddress(EBX, 1 * index_scale + offset);
+ const intptr_t scale = Instance::ElementSizeFor(kTypedDataUint32ArrayCid);
+ const intptr_t offset = Instance::DataOffsetFor(kTypedDataUint32ArrayCid);
+ Address addr_0 = FieldAddress(EBX, 0 * scale + offset);
+ Address addr_1 = FieldAddress(EBX, 1 * scale + offset);
__ movl(EAX, Immediate(a_int32_value));
// 64-bit multiply EAX * value -> EDX:EAX.
__ mull(addr_0);
« no previous file with comments | « runtime/vm/intrinsifier_arm64.cc ('k') | runtime/vm/intrinsifier_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698