Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Side by Side Diff: runtime/vm/flow_graph_builder.cc

Issue 294223003: Last cross-platform cleanup in preparation of improved ARM code for indexed (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/flow_graph_builder.h" 5 #include "vm/flow_graph_builder.h"
6 6
7 #include "lib/invocation_mirror.h" 7 #include "lib/invocation_mirror.h"
8 #include "vm/ast_printer.h" 8 #include "vm/ast_printer.h"
9 #include "vm/bit_vector.h" 9 #include "vm/bit_vector.h"
10 #include "vm/class_finalizer.h" 10 #include "vm/class_finalizer.h"
(...skipping 2179 matching lines...) Expand 10 before | Expand all | Expand 10 after
2190 Value* array = Bind(new LoadLocalInstr(*tmp_var)); 2190 Value* array = Bind(new LoadLocalInstr(*tmp_var));
2191 Value* index = Bind(new ConstantInstr(Smi::ZoneHandle(Smi::New(i)))); 2191 Value* index = Bind(new ConstantInstr(Smi::ZoneHandle(Smi::New(i))));
2192 ValueGraphVisitor for_value(owner()); 2192 ValueGraphVisitor for_value(owner());
2193 node->ElementAt(i)->Visit(&for_value); 2193 node->ElementAt(i)->Visit(&for_value);
2194 Append(for_value); 2194 Append(for_value);
2195 // No store barrier needed for constants. 2195 // No store barrier needed for constants.
2196 const StoreBarrierType emit_store_barrier = 2196 const StoreBarrierType emit_store_barrier =
2197 for_value.value()->BindsToConstant() 2197 for_value.value()->BindsToConstant()
2198 ? kNoStoreBarrier 2198 ? kNoStoreBarrier
2199 : kEmitStoreBarrier; 2199 : kEmitStoreBarrier;
2200 intptr_t index_scale = FlowGraphCompiler::ElementSizeFor(class_id); 2200 const intptr_t index_scale = Instance::ElementSizeFor(class_id);
2201 StoreIndexedInstr* store = new StoreIndexedInstr( 2201 StoreIndexedInstr* store = new StoreIndexedInstr(
2202 array, index, for_value.value(), emit_store_barrier, 2202 array, index, for_value.value(), emit_store_barrier,
2203 index_scale, class_id, deopt_id, node->token_pos()); 2203 index_scale, class_id, deopt_id, node->token_pos());
2204 Do(store); 2204 Do(store);
2205 } 2205 }
2206 ReturnDefinition(ExitTempLocalScope(tmp_var)); 2206 ReturnDefinition(ExitTempLocalScope(tmp_var));
2207 } 2207 }
2208 } 2208 }
2209 2209
2210 2210
(...skipping 1763 matching lines...) Expand 10 before | Expand all | Expand 10 after
3974 LanguageError::kBailout, 3974 LanguageError::kBailout,
3975 Heap::kNew, 3975 Heap::kNew,
3976 "FlowGraphBuilder Bailout: %s %s", 3976 "FlowGraphBuilder Bailout: %s %s",
3977 String::Handle(function.name()).ToCString(), 3977 String::Handle(function.name()).ToCString(),
3978 reason)); 3978 reason));
3979 Isolate::Current()->long_jump_base()->Jump(1, error); 3979 Isolate::Current()->long_jump_base()->Jump(1, error);
3980 UNREACHABLE(); 3980 UNREACHABLE();
3981 } 3981 }
3982 3982
3983 } // namespace dart 3983 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698