Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Unified Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 294223003: Last cross-platform cleanup in preparation of improved ARM code for indexed (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_arm.cc
===================================================================
--- runtime/vm/flow_graph_compiler_arm.cc (revision 36576)
+++ runtime/vm/flow_graph_compiler_arm.cc (working copy)
@@ -1511,11 +1511,11 @@
for (intptr_t i = 0; i < len; i++) {
const bool is_last_check = (i == (len - 1));
Label next_test;
- assembler()->CompareImmediate(class_id_reg, sorted[i].cid);
+ __ CompareImmediate(class_id_reg, sorted[i].cid);
if (is_last_check) {
- assembler()->b(deopt, NE);
+ __ b(deopt, NE);
} else {
- assembler()->b(&next_test, NE);
+ __ b(&next_test, NE);
}
// Do not use the code from the function, but let the code be patched so
// that we can record the outgoing edges to other code.
@@ -1528,50 +1528,14 @@
AddStaticCallTarget(function);
__ Drop(argument_count);
if (!is_last_check) {
- assembler()->b(&match_found);
+ __ b(&match_found);
}
- assembler()->Bind(&next_test);
+ __ Bind(&next_test);
}
- assembler()->Bind(&match_found);
+ __ Bind(&match_found);
}
-Address FlowGraphCompiler::ElementAddressForIntIndex(intptr_t cid,
- intptr_t index_scale,
- Register array,
- intptr_t index) {
- UNREACHABLE();
- return FieldAddress(array, index);
-}
-
-
-Address FlowGraphCompiler::ElementAddressForRegIndex(intptr_t cid,
- intptr_t index_scale,
- Register array,
- Register index) {
- UNREACHABLE();
- return FieldAddress(array, index);
-}
-
-
-Address FlowGraphCompiler::ExternalElementAddressForIntIndex(
- intptr_t index_scale,
- Register array,
- intptr_t index) {
- UNREACHABLE();
- return FieldAddress(array, index);
-}
-
-
-Address FlowGraphCompiler::ExternalElementAddressForRegIndex(
- intptr_t index_scale,
- Register array,
- Register index) {
- UNREACHABLE();
- return FieldAddress(array, index);
-}
-
-
#undef __
#define __ compiler_->assembler()->
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698